Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755540AbZJ1Ugk (ORCPT ); Wed, 28 Oct 2009 16:36:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755230AbZJ1Ugj (ORCPT ); Wed, 28 Oct 2009 16:36:39 -0400 Received: from g4t0014.houston.hp.com ([15.201.24.17]:4716 "EHLO g4t0014.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755213AbZJ1Ugi (ORCPT ); Wed, 28 Oct 2009 16:36:38 -0400 Subject: Re: [dm-devel] [PATCH] block: silently error unsupported empty barriers too From: Andrew Patterson To: Mikulas Patocka Cc: Alasdair G Kergon , Mark McLoughlin , device-mapper development , Jens Axboe , Rusty Russell , linux-kernel , virtualization , ". troy.heber"@hp.com In-Reply-To: References: <1249557257.3721.55.camel@blaa> <20090806114550.GL29899@agk-dp.fab.redhat.com> Content-Type: text/plain Date: Wed, 28 Oct 2009 20:19:01 +0000 Message-Id: <1256761141.5830.79.camel@grinch> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1662 Lines: 50 On Thu, 2009-08-06 at 21:50 -0400, Mikulas Patocka wrote: > On Thu, 6 Aug 2009, Alasdair G Kergon wrote: > > > On Thu, Aug 06, 2009 at 12:14:17PM +0100, Mark McLoughlin wrote: > > > We should error all barriers, even empty barriers, on devices like > > > virtio_blk which don't support them. > > > > Have you considered whether or not virtio_blk actually needs to > > support empty barriers? > > > > Alasdair > > This is only for request-based drivers, where it is the responsibility of > blk-core to translate barriers. I think the empty barrier request anyway > in blk_do_ordered, but with an error message. So the patch changes it to > discard it early and queitly. It seems ok. > > Mikulas > -- This patch seems to have been dropped. I can reproduce the error using the following: 1. Create an LVM logical volume on top of a cciss device (note that the cciss driver does not support barriers) 2. Create an ext3 file system on top of the logical volume 3. Mount the file-system using -obarrier=1 4. Copy some files onto the file-system 5. Run sync (dm_flush is called) If I apply the patch (with some munging), the "end_request: I/O error, dev cciss/cXdY, sector 0" messages go away. This is not strictly a regression, given that the problem was introduced in 2.6.31, but I think it should still be fixed for 2.6.32. Andrew -- Andrew Patterson Hewlett-Packard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/