Message-ID: <4AE93B42.5040605@jp.fujitsu.com>
Date: Thu, 29 Oct 2009 15:50:42 +0900
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
User-Agent: Thunderbird 2.0.0.23 (Windows/20090812)
MIME-Version: 1.0
To: Roland Dreier <rdreier@cisco.com>
CC: linux-kernel@vger.kernel.org, x86@kernel.org,
       Andi Kleen <ak@linux.intel.com>, Thomas Gleixner <tglx@linutronix.de>,
       Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
       Mike Travis <travis@sgi.com>
Subject: Re: [PATCH] x86, mce: short output of MCE banks ownership information
References: <4AE90E43.2030709@jp.fujitsu.com> <adaaaza6exw.fsf@cisco.com>
In-Reply-To: <adaaaza6exw.fsf@cisco.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2179
Lines: 57

Roland Dreier wrote:
> Seems OK, but I think it would be even more useful to find a way to
> print fewer lines of output; with CPUs that will be released shortly, a
> system with 64 or even 128 logical CPUs will not be will not be that
> exotic, and producing 128 lines of kernel log output for debugging
> information that is rarely used and where the same info can be expressed
> in 2 or 3 lines is silly-looking (and very annoying on a 57600 bps
> serial console!).

Thanks for your review!

I think we could some effort like this for other messages during
CPU initialization.

For example I googled a full dmesg of recent hardware:
  http://www.gossamer-threads.com/lists/linux/kernel/1134265
It shows that the lines like:
   :
  Booting processor 1 APIC 0x2 ip 0x6000
  Initializing CPU#1 
  Calibrating delay using timer specific routine.. 5344.67 BogoMIPS (lpj=2672337) 
  CPU: Physical Processor ID: 0 
  CPU: Processor Core ID: 1 
  CPU: L1 I cache: 32K, L1 D cache: 32K 
  CPU: L2 cache: 256K 
  CPU: L3 cache: 8192K 
  mce: CPU supports 9 MCE banks 
  CPU1: Thermal monitoring enabled (TM1) 
  CPU 1 MCA banks CMCI:2 CMCI:3 CMCI:5 SHD:6 SHD:8 
  x86 PAT enabled: cpu 1, old 0x7040600070406, new 0x7010600070106 
  CPU1: Intel(R) Core(TM) i7 CPU 920 @ 2.67GHz stepping 04 
  Skipping synchronization checks as TSC is reliable. 
   :
are that printed for every cpu.

We already eliminated "mce: CPU supports X MCE banks" in this repeat
and now going to compress "CPU X MCA banks ..." line.

I suppose:
  - Cache information can be compressed too, could be in one line.
  - Usually model name (and also cache size) will be same on all cpu.

I can understand that it is better to avoid printing same lines
again and again.  But there are more redundant messages...

Maybe there would be more desirable ways, but I think that
"compress messages shorter to bear heavy repeating" will be
a good way at this time.


Thanks,
H.Seto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/