Date: Thu, 29 Oct 2009 14:19:44 +0100
From: Jens Axboe <jens.axboe@oracle.com>
To: Corrado Zoccolo <czoccolo@gmail.com>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>,
       Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PATCH] cfq-iosched: simplify prio-unboost code
Message-ID: <20091029131944.GN10727@kernel.dk>
References: <200910262136.03233.czoccolo@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200910262136.03233.czoccolo@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1282
Lines: 38

On Mon, Oct 26 2009, Corrado Zoccolo wrote:
> Eliminate redundant checks.
> 
> Signed-off-by: Corrado Zoccolo <czoccolo@gmail.com>
> ---
>  block/cfq-iosched.c |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
> index 6e9b395..244bc8a 100644
> --- a/block/cfq-iosched.c
> +++ b/block/cfq-iosched.c
> @@ -2611,12 +2611,10 @@ static void cfq_prio_boost(struct cfq_queue *cfqq)
>  			cfqq->ioprio = IOPRIO_NORM;
>  	} else {
>  		/*
> -		 * check if we need to unboost the queue
> +		 * unboost the queue (if needed)
>  		 */
> -		if (cfqq->ioprio_class != cfqq->org_ioprio_class)
> -			cfqq->ioprio_class = cfqq->org_ioprio_class;
> -		if (cfqq->ioprio != cfqq->org_ioprio)
> -			cfqq->ioprio = cfqq->org_ioprio;
> +		cfqq->ioprio_class = cfqq->org_ioprio_class;
> +		cfqq->ioprio = cfqq->org_ioprio;
>  	}

Not sure I see much gain in that, the previous code makes it explicit
that it may not be different and avoid dirtying cfqq if it isn't.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/