Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754290AbZJ2VjF (ORCPT ); Thu, 29 Oct 2009 17:39:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753030AbZJ2VjE (ORCPT ); Thu, 29 Oct 2009 17:39:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61680 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752900AbZJ2VjD (ORCPT ); Thu, 29 Oct 2009 17:39:03 -0400 Message-ID: <4AEA0B71.5050805@redhat.com> Date: Thu, 29 Oct 2009 16:38:57 -0500 From: Eric Sandeen User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: Parag Warudkar CC: "Aneesh Kumar K.V" , Theodore Tso , LKML , linux-ext4@vger.kernel.org, bugzilla-daemon@bugzilla.kernel.org Subject: Re: [Bug 14354] Re: ext4 increased intolerance to unclean shutdown? References: <20091016091558.GA10184@mit.edu> <20091027101534.GA27584@skywalker.linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1512 Lines: 39 Parag Warudkar wrote: > On Tue, Oct 27, 2009 at 6:15 AM, Aneesh Kumar K.V > wrote: >> Can you try this patch ? >> >> commit a8836b1d6f92273e001012c7705ae8f4c3d5fb65 >> Author: Aneesh Kumar K.V >> Date: Tue Oct 27 15:36:38 2009 +0530 >> >> ext4: discard preallocation during truncate >> >> We need to make sure when we drop and reacquire the inode's >> i_data_sem we discard the inode preallocation. Otherwise we >> could have blocks marked as free in bitmap but still belonging >> to prealloc space. > > Just wanted to let you know that I have applied this patch and one > unclean shutdown later it seems to have not given me any trouble. > > I will continue testing it - hopefully I won't have to reformat this > time ( every time I tested previously I ended up having weird issues > that I decided to get rid of by reformatting /). I've been running my testcase, and I just hit the usual corruption with this patch in place after 8 iterations, I'm afraid. -Eric > Parag > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/