Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757374AbZJ3TsH (ORCPT ); Fri, 30 Oct 2009 15:48:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756019AbZJ3TsF (ORCPT ); Fri, 30 Oct 2009 15:48:05 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:43958 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754088AbZJ3TsE (ORCPT ); Fri, 30 Oct 2009 15:48:04 -0400 Date: Fri, 30 Oct 2009 12:47:38 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: "Rafael J. Wysocki" cc: Linux Kernel Mailing List , Kernel Testers List , Greg Kroah-Hartman , Jose Marino , ACPI Devel Maling List , Linux PCI , Dominik Brodowski Subject: Re: Help needed, Re: [Bug #14334] pcmcia suspend regression from 2.6.31.1 to 2.6.31.2 - Dell Inspiron 600m In-Reply-To: <200910301948.24473.rjw@sisk.pl> Message-ID: References: <6dRYo8ss7vL.A.EqH.Nse5KB@chimera> <200910301948.24473.rjw@sisk.pl> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1144 Lines: 28 On Fri, 30 Oct 2009, Rafael J. Wysocki wrote: > > > 1) Resume works if pcmcia_socket_dev_resume(dev) is moved to the "regular" > resume phase, after resume_device_irqs(). Hmm. We really probably shouldn't call pcmcia_socket_dev_resume() in early_resume. It takes mutexes etc, and it calls "socket_resume()", which sleeps etc. That per se should be ok these days (since we don't actualyl disable CPU irq's, just device irqs), but it also does that whole card insertion events etc. And _that_ code I wouldn't trust at all. The PCMCIA code is better than it used to be a long time ago, but some of it is still pretty crazy. I get the feeling that we should just revert that commit 0c570cdeb, and instead always do PCMCIA suspend as a "eject" event. That way we have no driver behind it to resume at resume time - and we'll see any plugged-in device as just a new insertion. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/