DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=ZWXuW0boeH6QF9wT3c6GRyUUbqgJdaflr5XX4PppETEUcxAJXbtVmwJFRQwAwZG818
         R/kxXhyziy63O6IwNH46ZqqPKDJhJEuuxVFjIdJjkTdEGPmYnHRQr9Uncux8PuOY4GQ2
         oDzsMCcVKVPRRiCLHyurFv9JgRMsiloquxvQs=
Date: Sat, 31 Oct 2009 12:44:31 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86, apicdef: Fix checkpatch issues in apicdef.h
Message-ID: <20091031094431.GB4869@lenovo>
References: <b9df5fa10910310229s2d9f85c1y31403ecbf8c31567@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b9df5fa10910310229s2d9f85c1y31403ecbf8c31567@mail.gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 881
Lines: 26

[Rakib Mullick - Sat, Oct 31, 2009 at 03:29:32PM +0600]
|
|  In apicdef.h - we have a checkpatch issue - needs to be fixed.
| We were warned by the following checkpatch warning:
| 
| ERROR: space prohibited before that ':' (ctx:WxW)
| #276: FILE: arch/x86/include/asm/apicdef.h:376:
| +                       hi      : 1;
|                                 ^
| ---
| Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
| 

Hi Rakib,

personally I would not change it even having checkpatch
issue. Really, it's easier to read this bitfield width
aligned rather then moved left. But this is a personal
opinion only (sorry).

	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/