Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933297AbZJaVuy (ORCPT ); Sat, 31 Oct 2009 17:50:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757731AbZJaVux (ORCPT ); Sat, 31 Oct 2009 17:50:53 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:59214 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754497AbZJaVuw (ORCPT ); Sat, 31 Oct 2009 17:50:52 -0400 From: "Rafael J. Wysocki" To: Linus Torvalds Subject: Re: Help needed, Re: [Bug #14334] pcmcia suspend regression from 2.6.31.1 to 2.6.31.2 - Dell Inspiron 600m Date: Sat, 31 Oct 2009 22:52:39 +0100 User-Agent: KMail/1.12.1 (Linux/2.6.32-rc5-rjw; KDE/4.3.1; x86_64; ; ) Cc: Benjamin Herrenschmidt , Linux Kernel Mailing List , Kernel Testers List , "Greg Kroah-Hartman" , Jose Marino , ACPI Devel Maling List , Linux PCI , Dominik Brodowski References: <200910312227.15493.rjw@sisk.pl> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200910312252.39446.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1127 Lines: 29 On Saturday 31 October 2009, Linus Torvalds wrote: > > On Sat, 31 Oct 2009, Rafael J. Wysocki wrote: > > > > The patch is appended, please have a look. > > Looks sane to me. It does the actual real socket ops early, and does the > crazy pcmcia resume late. > > And I like how you abstracted out that dev->socket thing in > pcmcia_socket_dev_run(). > > The only thing that looks odd is how you do "socket_start_resume()" in the > "late_resume" path too - that has already been done by the early_resume, > and as far as I can see you're now initializing the socket twice. > > Is there a reason for that? Or am I misreading the patch (I didn't > actually apply it, I just read the patch itself). Yes, there is, because socket_early_resume() only does it in the (skt->state & SOCKET_PRESENT) case. If that bit is not set, the initialization is entirely postponed. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/