Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754302AbZKBJ5x (ORCPT ); Mon, 2 Nov 2009 04:57:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754198AbZKBJ5w (ORCPT ); Mon, 2 Nov 2009 04:57:52 -0500 Received: from ns.penguin.cz ([84.21.108.25]:48179 "EHLO ns.penguin.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754114AbZKBJ5w (ORCPT ); Mon, 2 Nov 2009 04:57:52 -0500 Subject: Re: Possible suspend/resume regression in .32-rc? From: Stanislav Brabec To: Haojian Zhuang Cc: Pavel Machek , dsaxena@laptop.org, alan@linux.intel.com, gregkh@suse.de, Daniel Mack , linux-arm-kernel@lists.infradead.org, Eric , Haojian Zhuang , rpurdie@rpsys.net, lenz@cs.wisc.edu, kernel list , Dirk@opfer-online.de, arminlitzel@web.de, Cyril Hrubis , thommycheck@gmail.com, dbaryshkov@gmail.com, omegamoon@gmail.com, "Rafael J. Wysocki" In-Reply-To: <771cded00911020122o3bb5cc96q957c8be1ce7cae46@mail.gmail.com> References: <20091031013427.GL14091@buzzloop.caiaq.de> <20091101205449.GT14091@buzzloop.caiaq.de> <20091101213343.GA31345@elf.ucw.cz> <20091101220341.GA16698@elf.ucw.cz> <771cded00911020122o3bb5cc96q957c8be1ce7cae46@mail.gmail.com> Content-Type: text/plain Date: Mon, 02 Nov 2009 10:57:53 +0100 Message-Id: <1257155873.5642.14.camel@utx.utx.cz> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 994 Lines: 25 Haojian Zhuang wrote: > Commit b5b82df6, from May 2007, breaks no_console_suspend on the OLPC > XO laptop. Basically what happens is that upon returning from resume, > serial8250_resume_port() will reconfigure the port for high speed > mode and all console output will be garbled, making debug of the > resume path painful. This patch modifies uart_resume_port() to > reset the port to the state it was in before we suspended. See my patch waiting for approval in LKML thread "serial-core: resume serial hardware with no_console_suspend". It attempts to fix it, but I was not yet able to test it due to spitz resume breakage. ________________________________________________________________________ Stanislav Brabec http://www.penguin.cz/~utx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/