Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754658AbZKBKHf (ORCPT ); Mon, 2 Nov 2009 05:07:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754365AbZKBKHd (ORCPT ); Mon, 2 Nov 2009 05:07:33 -0500 Received: from cantor2.suse.de ([195.135.220.15]:58504 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754373AbZKBKHA (ORCPT ); Mon, 2 Nov 2009 05:07:00 -0500 From: Jan Blunck To: linux-fsdevel@vger.kernel.org Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, Jan Blunck , Andrew Morton , Andreas Dilger , Jan Kara , Al Viro , "Theodore Ts'o" , linux-ext4@vger.kernel.org Subject: [PATCH 07/27] BKL: Remove BKL from ext3_put_super() and ext3_remount() Date: Mon, 2 Nov 2009 11:04:47 +0100 Message-Id: <1257156307-24175-8-git-send-email-jblunck@suse.de> X-Mailer: git-send-email 1.6.4.2 In-Reply-To: <1257156307-24175-1-git-send-email-jblunck@suse.de> References: <1257156307-24175-1-git-send-email-jblunck@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1777 Lines: 66 The BKL lock is protecting the remounting against a potential call to ext3_put_super(). This could not happen, since this is protected by the s_umount rw semaphore of struct super_block. Therefore I think the BKL is protecting nothing here. Signed-off-by: Jan Blunck --- fs/ext3/super.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 4b635b7..3ddce03 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c @@ -398,8 +398,6 @@ static void ext3_put_super (struct super_block * sb) struct ext3_super_block *es = sbi->s_es; int i, err; - lock_kernel(); - ext3_xattr_put_super(sb); err = journal_destroy(sbi->s_journal); sbi->s_journal = NULL; @@ -448,8 +446,6 @@ static void ext3_put_super (struct super_block * sb) sb->s_fs_info = NULL; kfree(sbi->s_blockgroup_lock); kfree(sbi); - - unlock_kernel(); } static struct kmem_cache *ext3_inode_cachep; @@ -2495,8 +2491,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) int i; #endif - lock_kernel(); - /* Store the original options */ lock_super(sb); old_sb_flags = sb->s_flags; @@ -2607,7 +2601,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) kfree(old_opts.s_qf_names[i]); #endif unlock_super(sb); - unlock_kernel(); return 0; restore_opts: sb->s_flags = old_sb_flags; @@ -2625,7 +2618,6 @@ restore_opts: } #endif unlock_super(sb); - unlock_kernel(); return err; } -- 1.6.4.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/