DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=pK4BCgXg4fDQaq9/qa+kX6JcoNUxjDNj7JlVtvtV9MGdznwFRkObgNlHkS+ZdS6EB3
         xX2rfa5gspJESWyd9dpnO7ARHP98RGE7dPiKMvCGD2u7VltUAqqK6SJnBPXjrFTqCWUA
         mGv+xfzXzxwylSzBg9uAUnqLf2Tk6t8/u9kGk=
MIME-Version: 1.0
In-Reply-To: <4AEEBDD8.5080808@gmail.com>
References: <4AEEBDD8.5080808@gmail.com>
From: Mike Frysinger <vapier.adi@gmail.com>
Date: Mon, 2 Nov 2009 08:00:53 -0500
Message-ID: <8bd0f97a0911020500r793d7414mb55c2ec8c62250f4@mail.gmail.com>
Subject: Re: [PATCH] Blackfin arch: ensure index is positive
To: Roel Kluin <roel.kluin@gmail.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
       Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1001
Lines: 25

On Mon, Nov 2, 2009 at 06:09, Roel Kluin wrote:
> The indices are signed, it's not negative before we read an
> array element.
>
> Found by code analysis, is this required?
>
> --- a/arch/blackfin/kernel/gptimers.c
> +++ b/arch/blackfin/kernel/gptimers.c
> @@ -139,7 +139,7 @@ static uint32_t const timil_mask[MAX_BLACKFIN_GPTIMERS] =
>
>  void set_gptimer_pwidth(int timer_id, uint32_t value)
>  {
> -       tassert(timer_id < MAX_BLACKFIN_GPTIMERS);
> +       tassert(timer_id < MAX_BLACKFIN_GPTIMERS && timer_id >= 0);

the gptimer API is supposed to use symbolic defines only (TIMER#_id),
but that doesnt mean people couldnt pass in negative numbers
themselves.  but rather than fix it this way, i'll change the API to
use unsigned ints.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/