Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S312935AbSCZDx6>; Mon, 25 Mar 2002 22:53:58 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S312936AbSCZDxt>; Mon, 25 Mar 2002 22:53:49 -0500
Received: from mx7.sac.fedex.com ([199.81.194.38]:29963 "EHLO
	mx7.sac.fedex.com") by vger.kernel.org with ESMTP
	id <S312935AbSCZDxk>; Mon, 25 Mar 2002 22:53:40 -0500
Date: Tue, 26 Mar 2002 11:50:56 +0800 (SGT)
From: Jeff Chua <jchua@fedex.com>
X-X-Sender: jchua@silk.corp.fedex.com
To: Andre Hedrick <andre@linux-ide.org>
cc: Jeff Chua <jeffchua@silk.corp.fedex.com>,
        Marcelo Tosatti <marcelo@conectiva.com.br>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Jeff Chua <jchua@fedex.com>
Subject: Re: [PATCH] 2.4.19-pre4 ide-probe
In-Reply-To: <Pine.LNX.4.10.10203221447260.11833-200000@master.linux-ide.org>
Message-ID: <Pine.LNX.4.42.0203261149510.15967-100000@silk.corp.fedex.com>
MIME-Version: 1.0
X-MIMETrack: Itemize by SMTP Server on ENTPM11/FEDEX(Release 5.0.8 |June 18, 2001) at 03/26/2002
 11:53:32 AM,
	Serialize by Router on ENTPM11/FEDEX(Release 5.0.8 |June 18, 2001) at 03/26/2002
 11:53:35 AM,
	Serialize complete at 03/26/2002 11:53:35 AM
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 22 Mar 2002, Andre Hedrick wrote:

> This is the bases of the codes origin.

So, should it be removed then? If not, how can you get rid of the
ide_xlate_1024 unknown symbol?

Jeff.



>
> Comments?
>
> Andre Hedrick
> LAD Storage Consulting Group
>
> On Thu, 21 Mar 2002, Jeff Chua wrote:
>
> >
> > Marcelo, Andre,
> >
> > Someone apparently added the "hook", but it was never used in the kernel,
> >
> > What is ide_xlate_1024 referring to?
> >
> > Jeff
> >
> > ---------- Forwarded message ----------
> > Date: Thu, 14 Mar 2002 11:22:27 +0800 (SGT)
> > From: Jeff Chua <jeffchua@silk.corp.fedex.com>
> > To: Linux Kernel <linux-kernel@vger.kernel.org>,
> >      Marcelo Tosatti <marcelo@conectiva.com.br>
> > Cc: Jeff Chua <jchua@fedex.com>
> > Subject: [PATCH] 2.4.19-pre3 ide_xlate_1024_hook ???
> >
> >
> > It seems that the "ide_xlate_1024_hook" is redundant in
> > ./drivers/ide/ide-probe.c
> >
> > It's not used anywhere by the kernel, and it caused "depmod" to fail
> > with unknown ide_xlate_1024_hook symbol.
> >
> >
> > Jeff
> >
> > Patch ...
> >
> > --- ./drivers/ide/ide-probe.c.org       Thu Mar 14 11:01:20 2002
> > +++ ./drivers/ide/ide-probe.c   Thu Mar 14 11:03:16 2002
> > @@ -987,7 +987,6 @@
> >  }
> >
> >  #ifdef MODULE
> > -extern int (*ide_xlate_1024_hook)(kdev_t, int, int, const char *);
> >
> >  int init_module (void)
> >  {
> > @@ -997,14 +996,12 @@
> >                 ide_unregister(index);
> >         ideprobe_init();
> >         create_proc_ide_interfaces();
> > -       ide_xlate_1024_hook = ide_xlate_1024;
> >         return 0;
> >  }
> >
> >  void cleanup_module (void)
> >  {
> >         ide_probe = NULL;
> > -       ide_xlate_1024_hook = 0;
> >  }
> >  MODULE_LICENSE("GPL");
> >  #endif /* MODULE */
> >
> >
> >
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/