Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752505AbZKCPHn (ORCPT ); Tue, 3 Nov 2009 10:07:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751544AbZKCPHm (ORCPT ); Tue, 3 Nov 2009 10:07:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32411 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752188AbZKCPHl (ORCPT ); Tue, 3 Nov 2009 10:07:41 -0500 Message-ID: <4AF04717.3020008@redhat.com> Date: Tue, 03 Nov 2009 10:07:03 -0500 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: Ingo Molnar CC: Arnaldo Carvalho de Melo , =?ISO-8859-1?Q?Fr=E9d=E9r?= =?ISO-8859-1?Q?ic_Weisbecker?= , lkml , Steven Rostedt , Jim Keniston , Ananth N Mavinakayanahalli , Christoph Hellwig , "Frank Ch. Eigler" , "H. Peter Anvin" , Jason Baron , "K.Prasad" , Peter Zijlstra , Srikar Dronamraju , systemtap , DLE Subject: Re: [PATCH -tip perf/probes 00/10] x86 insn decoder bugfixes and perf-probe syntax changes References: <20091027204156.30545.96425.stgit@harusame> <20091029085348.GD26970@elte.hu> <4AE9C919.4070003@redhat.com> <4AEF4C29.2060501@redhat.com> <4AEF7B22.50705@redhat.com> <20091103073236.GB19928@elte.hu> In-Reply-To: <20091103073236.GB19928@elte.hu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1585 Lines: 48 Ingo Molnar wrote: > * Masami Hiramatsu wrote: >> Masami Hiramatsu wrote: >>> Masami Hiramatsu wrote: >>>> Ingo Molnar wrote: >>>>> What we want here is two fold: >>>>> >>>>> - enable kprobes event support when perf events is enabled and kprobes >>>>> is enabled. We dont want another config option for it. >>>> >>>> Sure, at least that combination should enable kprobe-tracer forcibly. >>> >>> Hmm, someone may not want to enables kprobe-tracer. Perhaps, >>> "default y if (EVENT_PROFILE)" is enough, isn't it? >> >> Oops, this causes recursive dependency error :-( >> >> kernel/trace/Kconfig:90:error: found recursive dependency: TRACING -> >> EVENT_TRACING -> EVENT_PROFILE -> KPROBE_TRACER -> GENERIC_TRACER -> TRACING > > This dependency problem can be resolved by simply making it 'default y' > - the option itself depends on KPROBES already, which is default-off - > so no need to also make it depend on EVENT_PROFILE. OK, > btw., it would be nice to re-name it to 'KPROBE_EVENTS'. If the probe > point is used as a count - like in the __switch_to example i cited - > there's no tracing going on at all. Sure, it's not a tracer anyway :-) Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/