Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755437AbZKCWOD (ORCPT ); Tue, 3 Nov 2009 17:14:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755322AbZKCWOC (ORCPT ); Tue, 3 Nov 2009 17:14:02 -0500 Received: from out02.mta.xmission.com ([166.70.13.232]:45633 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755234AbZKCWOB (ORCPT ); Tue, 3 Nov 2009 17:14:01 -0500 To: "Serge E. Hallyn" Cc: Greg Kroah-Hartman , Kay Sievers , Greg KH , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, Eric Dumazet , Benjamin LaHaise , "Eric W. Biederman" Subject: Re: [PATCH 01/13] sysfs: Update sysfs_setxattr so it updates secdata under the sysfs_mutex References: <1257249429-12384-1-git-send-email-ebiederm@xmission.com> <20091103134823.GB31981@us.ibm.com> <20091103213129.GA13555@us.ibm.com> From: ebiederm@xmission.com (Eric W. Biederman) Date: Tue, 03 Nov 2009 14:13:52 -0800 In-Reply-To: <20091103213129.GA13555@us.ibm.com> (Serge E. Hallyn's message of "Tue\, 3 Nov 2009 15\:31\:29 -0600") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-XM-SPF: eid=;;;mid=;;;hst=in02.mta.xmission.com;;;ip=76.21.114.89;;;frm=ebiederm@xmission.com;;;spf=neutral X-SA-Exim-Connect-IP: 76.21.114.89 X-SA-Exim-Mail-From: ebiederm@xmission.com X-SA-Exim-Version: 4.2.1 (built Thu, 25 Oct 2007 00:26:12 +0000) X-SA-Exim-Scanned: No (on in02.mta.xmission.com); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 713 Lines: 21 "Serge E. Hallyn" writes: > > Gah, sorry. No prob. > Acked-by: Serge Hallyn > > (as an aside, I can't see any reason to not just return if strncmp(name, > XATTR_SECURITY_PREFIX,) above to avoid a level of indent and needless gotos) Sounds like it is worth a patch. For now I'm concentrating on getting this patchset merged, and extraneous cleanups have a way of dragging the process out beyond what time I have to give. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/