Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754564AbZKDEL6 (ORCPT ); Tue, 3 Nov 2009 23:11:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752331AbZKDEL5 (ORCPT ); Tue, 3 Nov 2009 23:11:57 -0500 Received: from out02.mta.xmission.com ([166.70.13.232]:38588 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751811AbZKDEL4 (ORCPT ); Tue, 3 Nov 2009 23:11:56 -0500 To: "Serge E. Hallyn" Cc: Greg Kroah-Hartman , Kay Sievers , Greg KH , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, Eric Dumazet , Benjamin LaHaise , "Eric W. Biederman" Subject: Re: [PATCH 07/13] sysfs: Update s_iattr on link and unlink. References: <1257249429-12384-7-git-send-email-ebiederm@xmission.com> <20091104035413.GD27639@us.ibm.com> From: ebiederm@xmission.com (Eric W. Biederman) Date: Tue, 03 Nov 2009 20:11:56 -0800 In-Reply-To: <20091104035413.GD27639@us.ibm.com> (Serge E. Hallyn's message of "Tue\, 3 Nov 2009 21\:54\:13 -0600") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-XM-SPF: eid=;;;mid=;;;hst=in01.mta.xmission.com;;;ip=76.21.114.89;;;frm=ebiederm@xmission.com;;;spf=neutral X-SA-Exim-Connect-IP: 76.21.114.89 X-SA-Exim-Mail-From: ebiederm@xmission.com X-SA-Exim-Version: 4.2.1 (built Thu, 25 Oct 2007 00:26:12 +0000) X-SA-Exim-Scanned: No (on in01.mta.xmission.com); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 28 "Serge E. Hallyn" writes: > Quoting Eric W. Biederman (ebiederm@xmission.com): >> From: Eric W. Biederman >> >> Currently sysfs updates the timestamps on the vfs directory >> inode when we create or remove a directory entry but doesn't >> update the cached copy on the sysfs_dirent, fix that oversight. > > confused... why not do this in sysfs_addrm_finish()? > > I guess you'd have to do at it at top before dropping sysfs_mutex > so it wouldn't be as pretty as I was thinking, but at least you > could just do it once. Well sysfs_addrm_finish doesn't really know if you did anything. Beyond that my ultimate goal is to kill sysfs_addrm_start and sysfs_addrm_finish. Of course that requires fixing all of the sysfs users that depend on the impossible to get right recursive directory removal in sysfs, so it is not the subject of this patchset. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/