Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751892AbZKDHvt (ORCPT ); Wed, 4 Nov 2009 02:51:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751486AbZKDHvs (ORCPT ); Wed, 4 Nov 2009 02:51:48 -0500 Received: from [95.166.99.235] ([95.166.99.235]:39138 "EHLO kernel.dk" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751039AbZKDHvr (ORCPT ); Wed, 4 Nov 2009 02:51:47 -0500 Date: Wed, 4 Nov 2009 08:51:52 +0100 From: Jens Axboe To: Jeff Moyer Cc: Corrado Zoccolo , Linux-Kernel Subject: Re: Fwd: [PATCH 0/5] cfq-iosched: improve latency for no-idle queues (v3) Message-ID: <20091104075152.GX8742@kernel.dk> References: <4e5e476b0911030042q5963718aj5875c542e6f6cc40@mail.gmail.com> <4e5e476b0911030719m425c208cg311f44a91fad8342@mail.gmail.com> <4e5e476b0911031035l7caffcb7n36b6eddd399864e7@mail.gmail.com> <20091103201802.GL8742@kernel.dk> <20091103202836.GM8742@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1462 Lines: 35 On Tue, Nov 03 2009, Jeff Moyer wrote: > Jens Axboe writes: > > > On Tue, Nov 03 2009, Jeff Moyer wrote: > >> Jens Axboe writes: > >> > >> > Since for-linus contains conflicting changes, can you and Jeff please > >> > double check that everything is still in order? The interesting bit here > >> > is the merge with for-2.6.33 and the coop limit from Shaohua Li. I did > >> > the straight forward merge, but we likely just need to drop that logic > >> > since the coop concept is radically different given that we merge and > >> > break queues in for-2.6.33. > >> > >> Yeah, since I changed the meaning of the cfqq_coop flag, a lot of those > >> tests are just plain wrong. Let me play with it and I'll send you an > >> incremental patch in a bit. > > > > Thanks, here's what I have. It's basically a revert of the commit in > > question. > > Your patch looks like a straight-forward revert. I still think we need > some guards in place, though. For now, I think we can go with what you > have, and I'll come up with some other mechanism to deal with this case. Thanks Jeff, I'll merge it up and we can get things straightened out in due time. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/