DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=w2UJ5tKAZUgiUrusKk1xyCwUSDsqAAdBHouqHE/2CQ91Yiqeb2h9Z0HN/8A3cejzi7
         ZU5iZexGwaKxzdZXYamIo6HeNv5QYE4D+uNvEOxZcacWeNyRomyECR4MWA/LfK2uWq3q
         MRG+OCeNutAPVMovFEPhTGhwODXkDsEtnfWx8=
MIME-Version: 1.0
In-Reply-To: <1257296148.2891.223.camel@dhcp231-106.rdu.redhat.com>
References: <20091031184721.17244.16465.stgit@paris.rdu.redhat.com>
	 <20091031184819.17244.55795.stgit@paris.rdu.redhat.com>
	 <20091103165947.35bd78d7@bike.lwn.net>
	 <1257296148.2891.223.camel@dhcp231-106.rdu.redhat.com>
Date: Wed, 4 Nov 2009 09:07:42 +0100
Message-ID: <19f34abd0911040007i738bfc4eq5481b6c85117d525@mail.gmail.com>
Subject: Re: [PATCH 10/10] send events using read
From: Vegard Nossum <vegard.nossum@gmail.com>
To: Eric Paris <eparis@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>, linux-kernel@vger.kernel.org,
       linus-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
       hch@infradead.org, agruen@suse.de
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1057
Lines: 25

2009/11/4 Eric Paris <eparis@redhat.com>:
> On Tue, 2009-11-03 at 16:59 -0700, Jonathan Corbet wrote:
>> Hi, Eric,
>>
>> This is not a full review, but I did notice a problem as I was trying to
>> figure out the new API...
>
> This is a rip off of inotify which was introduced in commit 3632dee2f8b
> from Vegard Nossum back in January.  I can't seem to find any discussion
> of this before it went into Linus' tree, so if someone knows how this
> patch got to Linus and what was said about it, I'd like to know.  Thanks
> for unwittingly finding and inotify bug!

I don't have a git tree handy, but I think this is the locking
imbalance fix. It went to the security list, so that's probably why
you didn't find it. As far as I can tell, the code in question was
wrong even before that patch, though.


Vegard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/