Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754569AbZKDJBp (ORCPT ); Wed, 4 Nov 2009 04:01:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751946AbZKDJBo (ORCPT ); Wed, 4 Nov 2009 04:01:44 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:54998 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751466AbZKDJBn (ORCPT ); Wed, 4 Nov 2009 04:01:43 -0500 Date: Wed, 4 Nov 2009 10:01:40 +0100 From: Pavel Machek To: David Rientjes Cc: Christoph Lameter , Rik van Riel , Andrew Morton , Mel Gorman , stable@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Frans Pop , Jiri Kosina , Sven Geggus , Karol Lewandowski , Tobias Oetiker , KOSAKI Motohiro , Pekka Enberg , Stephan von Krawczynski , kernel-testers@vger.kernel.org Subject: Re: [PATCH 2/3] page allocator: Do not allow interrupts to use ALLOC_HARDER Message-ID: <20091104090140.GA14694@elf.ucw.cz> References: <20091027130924.fa903f5a.akpm@linux-foundation.org> <20091031184054.GB1475@ucw.cz> <20091031201158.GB29536@elf.ucw.cz> <4AECCF6A.4020206@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 20 > I hope we can move this to another thread if people would like to remove > this exemption completely instead of talking about this trivial fix, which > I doubt there's any objection to. I'm arguing that this "trivial fix" is wrong, and that you should just remove those two lines. If going into reserves from interrupts hurts, doing that from task context will hurt, too. "realtime" task should not be normally allowed to "hurt" the system like that. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/