Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755364AbZKDKxq (ORCPT ); Wed, 4 Nov 2009 05:53:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755338AbZKDKxp (ORCPT ); Wed, 4 Nov 2009 05:53:45 -0500 Received: from bitbox.plus.com ([81.174.226.42]:50702 "EHLO pangolin.localnet" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755029AbZKDKxo (ORCPT ); Wed, 4 Nov 2009 05:53:44 -0500 Message-ID: <4AF15D6A.5020403@bitbox.co.uk> Date: Wed, 04 Nov 2009 10:54:34 +0000 From: Peter Horton User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Andrew Morton Cc: ecashin@coraid.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] prevent AoE causing cache aliases References: <20091022142228.GA18986@bitbox.co.uk> <20091103163755.57d3530c.akpm@linux-foundation.org> In-Reply-To: <20091103163755.57d3530c.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2661 Lines: 86 Andrew Morton wrote: > On Thu, 22 Oct 2009 15:22:28 +0100 > phorton@bitbox.co.uk (Peter Horton) wrote: > >> To: ecashin@coraid.com > > Have you heard back from Ed on this? > No. >> Cc: linux-kernel@vger.kernel.org >> Subject: [PATCH] prevent AoE causing cache aliases >> Date: Thu, 22 Oct 2009 15:22:28 +0100 >> Sender: linux-kernel-owner@vger.kernel.org >> User-Agent: Mutt/1.5.9i >> >> This patch prevents the AoE block driver from creating cache aliases of >> page cache pages on machines with virtually indexed caches. >> >> Building kernels on an AT91SAM9G20 board without this patch fails with >> segmentation faults after a couple of passes. >> >> >> Index: linux-2.6.31/drivers/block/aoe/aoecmd.c >> =================================================================== >> --- linux-2.6.31.orig/drivers/block/aoe/aoecmd.c 2009-09-09 23:13:59.000000000 +0100 >> +++ linux-2.6.31/drivers/block/aoe/aoecmd.c 2009-10-22 10:24:50.000000000 +0100 >> @@ -735,6 +735,21 @@ >> part_stat_unlock(); >> } >> >> +/* >> + * Ensure we don't create aliases in VI caches >> + */ >> +static inline void >> +killalias(struct bio *bio) >> +{ >> + struct bio_vec *bv; >> + int i; >> + >> + if (bio_data_dir(bio) == READ) >> + __bio_for_each_segment(bv, bio, i, 0) { >> + flush_dcache_page(bv->bv_page); >> + } >> +} >> + >> void >> aoecmd_ata_rsp(struct sk_buff *skb) >> { >> @@ -853,8 +868,12 @@ >> >> if (buf && --buf->nframesout == 0 && buf->resid == 0) { >> diskstats(d->gd, buf->bio, jiffies - buf->stime, buf->sector); >> - n = (buf->flags & BUFFL_FAIL) ? -EIO : 0; >> - bio_endio(buf->bio, n); >> + if (buf->flags & BUFFL_FAIL) >> + bio_endio(buf->bio, -EIO); >> + else { >> + killalias(buf->bio); >> + bio_endio(buf->bio, 0); >> + } >> mempool_free(buf, d->bufpool); >> } > > Looks OK. > > This bugfix will cause a pointless __bio_for_each_segment() busywait > loop to be executed on architectures for which flush_dcache_page() is a > no-op. > > We don't have infrastructure to fix that. Couldn't we add a flag to the bio that users could set to indicate that they are not house trained with respect to the D-cache (i.e non-DMA drivers). Architectures that needed to could then flush the relevant pages in the bio_endio() path somewhere. At the moment all the non-DMA block drivers need to be aware of the cache aliasing issue which means this problem keeps arising ... P. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/