Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756292AbZKDPQu (ORCPT ); Wed, 4 Nov 2009 10:16:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755929AbZKDPQt (ORCPT ); Wed, 4 Nov 2009 10:16:49 -0500 Received: from ey-out-2122.google.com ([74.125.78.24]:17283 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755892AbZKDPQs (ORCPT ); Wed, 4 Nov 2009 10:16:48 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=X65MgGcuFV1iA73nwyA2+dtzzpK7nUAiIg5lN9+v+1vB2v2OSZalswDGiZLVS0cRhM /kQRX3F+UL9zgRk76/ABBUabfLull1NjKyTebpIna5RLxCVA2lFGqqacfxd9h1QTnCmZ m6faFwaf8r0w6gfM5Gtg45wskpcjWqoIor7Rs= Subject: Re: [PATCH -queue v0 5/6] [loongson] rtc: enable legacy RTC driver on fuloong2f From: Wu Zhangjin Reply-To: wuzhangjin@gmail.com To: Ralf Baechle Cc: Arnaud Patard , linux-mips@linux-mips.org, LKML , huhb@lemote.com, yanh@lemote.com, Zhang Le , Thomas Gleixner , Nicholas Mc Guire , zhangfx@lemote.com, liujl@lemote.com In-Reply-To: <20091104141545.GA18408@linux-mips.org> References: <1257333527.8716.20.camel@falcon.domain.org> <20091104141545.GA18408@linux-mips.org> Content-Type: text/plain; charset="UTF-8" Organization: DSLab, Lanzhou University, China Date: Wed, 04 Nov 2009 23:12:59 +0800 Message-ID: <1257347585.16033.0.camel@falcon.domain.org> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1683 Lines: 38 On Wed, 2009-11-04 at 15:15 +0100, Ralf Baechle wrote: > On Wed, Nov 04, 2009 at 07:18:47PM +0800, Wu Zhangjin wrote: > > > In reality, fuloong2e, fuloong2f and yeeloong2f work fine with RTC_LIB, > > but relative patches need to append to drivers/rtc/rtc-cmos.c and also > > need a RTC platform device. If what I remembered is right, Gdium also > > need corresponding patches to make it work with RTC_LIB. > > > > Herein, I just let the basic support for those machines work, and then, > > the RTC_LIB support will be sent out later. > > > > and a small question: if legacy RTC driver works well on these machines, > > why should we forbid people to use it? I think it's better to remove the > > "select RTC_LIB" line for MIPS, and then, the people will be free to > > choose what they want, and even for the users whose platform not support > > RTC_LIB. > > RTC_LIB is the way to go; the non-RTC_LIB drivers are there only for > backward compatbility. A grep through the defcconfig files for all > platforms on all architectures finds that by now all have set > CONFIG_RTC_LIB and the remaining users of CONFIG_RTC, CONFIG_JS_RTC, > CONFIG_GEN_RTC, CONFIG_EFI_RTC, CONFIG_DS1302 (which all depend on !RTC_LIB) > are all defconfig files which seem to be slowly bitrotting. > > Time to axe !RTC_LIB? I'm tempted. > Okay, later, I will send the patches for RTC_LIB support asap, I'm testing it currently ;) Regards, Wu Zhangjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/