Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757655AbZKDTKg (ORCPT ); Wed, 4 Nov 2009 14:10:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757556AbZKDTKf (ORCPT ); Wed, 4 Nov 2009 14:10:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37671 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757540AbZKDTKe (ORCPT ); Wed, 4 Nov 2009 14:10:34 -0500 From: Jeff Moyer To: Vivek Goyal Cc: linux-kernel@vger.kernel.org, jens.axboe@oracle.com, nauman@google.com, dpshah@google.com, lizf@cn.fujitsu.com, ryov@valinux.co.jp, fernando@oss.ntt.co.jp, s-uchida@ap.jp.nec.com, taka@valinux.co.jp, guijianfeng@cn.fujitsu.com, balbir@linux.vnet.ibm.com, righi.andrea@gmail.com, m-ikeda@ds.jp.nec.com, akpm@linux-foundation.org, riel@redhat.com, kamezawa.hiroyu@jp.fujitsu.com Subject: Re: [PATCH 20/20] blkio: Drop the reference to queue once the task changes cgroup References: <1257291837-6246-1-git-send-email-vgoyal@redhat.com> <1257291837-6246-21-git-send-email-vgoyal@redhat.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Wed, 04 Nov 2009 14:09:40 -0500 In-Reply-To: <1257291837-6246-21-git-send-email-vgoyal@redhat.com> (Vivek Goyal's message of "Tue, 3 Nov 2009 18:43:57 -0500") Message-ID: User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 702 Lines: 18 Vivek Goyal writes: > o If a task changes cgroup, drop reference to the cfqq associated with io > context so that upon next request arrival we will allocate a new queue in > new group. You're doing more than dropping the reference, you're also setting the pointer in the cic to NULL. This is what you need to do, of course, but your changelog is misleading (and sounds incomplete, and sends off alarms in my head). Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/