Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932592AbZKDUzr (ORCPT ); Wed, 4 Nov 2009 15:55:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932299AbZKDUzr (ORCPT ); Wed, 4 Nov 2009 15:55:47 -0500 Received: from mail-pw0-f42.google.com ([209.85.160.42]:56867 "EHLO mail-pw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932267AbZKDUzp convert rfc822-to-8bit (ORCPT ); Wed, 4 Nov 2009 15:55:45 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=lejkMXwN8EY9fyO+5EMGafGdfESurz3AL9/OT0/xYUvCsQf0U6ngdoQ75e1laxdlRS oeGWoV0JT7rkLHuwxnVG/fWIUvwG9HMN0zF5SE1RpXbJ36WOoppUs2CPkKiMABfCB3p6 xNPVcRId3cxtGkCsVhHxLUplzKKqnL8GNpYaA= MIME-Version: 1.0 In-Reply-To: <20091104091106.32489ad7@jbarnes-piketon> References: <20091006173311.GA15751@auslistsprd01.us.dell.com> <4ACEE220.1020705@jp.fujitsu.com> <20091009182810.GB24889@mock.linuxdev.us.dell.com> <20091009183319.GC24889@mock.linuxdev.us.dell.com> <4AEA4C82.6010604@jp.fujitsu.com> <20091030025313.GA1042@mock.linuxdev.us.dell.com> <4AEA5C52.2030900@jp.fujitsu.com> <20091102175123.GA4028@mock.linuxdev.us.dell.com> <20091104091106.32489ad7@jbarnes-piketon> Date: Wed, 4 Nov 2009 12:55:50 -0800 Message-ID: <86802c440911041255i59024efckf496dfa966da8560@mail.gmail.com> Subject: Re: [PATCH] PCIe AER: honor ACPI HEST FIRMWARE FIRST mode From: Yinghai Lu To: Jesse Barnes Cc: Matt Domsch , Hidetoshi Seto , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Tom Long Nguyen , Zhang Yanmin , linux-kernel@vger.kernel.org, Kenji Kaneshige , Huong_Nguyen@dell.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2504 Lines: 57 On Wed, Nov 4, 2009 at 9:11 AM, Jesse Barnes wrote: > On Mon, 2 Nov 2009 11:51:24 -0600 > Matt Domsch wrote: > >> From 97ec121f91e5c76dc037f8d2abaea84c5476676e Mon Sep 17 00:00:00 2001 >> From: Matt Domsch >> Date: Thu, 8 Oct 2009 23:18:11 -0500 >> Subject: [PATCH] PCIe AER: honor ACPI HEST FIRMWARE FIRST mode >> >> Feedback from Hidetoshi Seto and Kenji Kaneshige incorporated. ?This >> correctly handles PCI-X bridges, PCIe root ports and endpoints, and >> prints debug messages when invalid/reserved types are found in the >> HEST. ?PCI devices not in domain/segment 0 are not represented in >> HEST, thus will be ignored. >> >> Today, the PCIe Advanced Error Reporting (AER) driver attaches itself >> to every PCIe root port for which BIOS reports it should, via ACPI >> _OSC. >> >> However, _OSC alone is insufficient for newer BIOSes. ?Part of ACPI >> 4.0 is the new APEI (ACPI Platform Error Interfaces) which is a way >> for OS and BIOS to handshake over which errors for which components >> each will handle. ?One table in ACPI 4.0 is the Hardware Error Source >> Table (HEST), where BIOS can define that errors for certain PCIe >> devices (or all devices), should be handled by BIOS ("Firmware First >> mode"), rather than be handled by the OS. >> >> Dell PowerEdge 11G server BIOS defines Firmware First mode in HEST, so >> that it may manage such errors, log them to the System Event Log, and >> possibly take other actions. ?The aer driver should honor this, and >> not attach itself to devices noted as such. >> >> Furthermore, Kenji Kaneshige reminded us to disallow changing the AER >> registers when respecting Firmware First mode. ?Platform firmware is >> expected to manage these, and if changes to them are allowed, it could >> break that firmware's behavior. >> >> The HEST parsing code may be replaced in the future by a more >> feature-rich implementation. ?This patch provides the minimum needed >> to prevent breakage until that implementation is available. >> >> Signed-off-by: Matt Domsch >> --- > > Applied to my linux-next branch, thanks. > can not find acpi_hest.c and acpi_hest.h maybe need to wait acpi hest code is there? YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/