Date: Thu, 5 Nov 2009 13:44:45 +0900
To: mingo@elte.hu
Cc: tj@kernel.org, joerg.roedel@amd.com, jbarnes@virtuousgeek.org,
       dwmw2@infradead.org, fujita.tomonori@lab.ntt.co.jp, x86@kernel.org,
       tglx@linutronix.de, hpa@zytor.com, athena@fftw.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: fix iommu=nodac parameter handling
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
In-Reply-To: <20091104122827.GB11968@elte.hu>
References: <4AE5B52A.4050408@kernel.org>
	<20091104122827.GB11968@elte.hu>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20091105134306W.fujita.tomonori@lab.ntt.co.jp>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1472
Lines: 39

On Wed, 4 Nov 2009 13:28:27 +0100
Ingo Molnar <mingo@elte.hu> wrote:

> 
> * Tejun Heo <tj@kernel.org> wrote:
> 
> > nodac should forbid dac instead of enabling it.  Fix it.
> > 
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> > Cc: Matteo Frigo <athena@fftw.org>
> > Cc: stable@kernel.org
> > ---
> > This was posted several months ago in a two patch series.  The second
> > one was rejected by Alan and with that the first one got lost too
> > although it's an apparent bug fix.  Matteo hit this bug recently and
> > reminded me about this patch.  So, regenerated and reposting.
> > 
> > Thanks.
> > 
> >  arch/x86/kernel/pci-dma.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
> > index d20009b..8cf3996 100644
> > --- a/arch/x86/kernel/pci-dma.c
> > +++ b/arch/x86/kernel/pci-dma.c
> > @@ -216,7 +216,7 @@ static __init int iommu_setup(char *p)
> >  		if (!strncmp(p, "allowdac", 8))
> >  			forbid_dac = 0;
> >  		if (!strncmp(p, "nodac", 5))
> > -			forbid_dac = -1;
> > +			forbid_dac = 1;
> >  		if (!strncmp(p, "usedac", 6)) {
> >  			forbid_dac = -1;
> >  			return 1;
> 
> (Cc:-ed more interested parties.)

Looks fine to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/