Date: Wed, 04 Nov 2009 23:22:14 -0800 (PST)
Message-Id: <20091104.232214.23355826.davem@davemloft.net>
To: gilad@codefidence.com
Cc: Valdis.Kletnieks@vt.edu, netdev@vger.kernel.org, ori@comsleep.com,
       linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH testing] Do not call IPv4 specific func in tcp_check_req
From: David Miller <davem@davemloft.net>
In-Reply-To: <1257352854-19490-1-git-send-email-gilad@codefidence.com>
References: <7916.1257300093@turing-police.cc.vt.edu>
	<1257352854-19490-1-git-send-email-gilad@codefidence.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 948
Lines: 26

From: Gilad Ben-Yossef <gilad@codefidence.com>
Date: Wed,  4 Nov 2009 18:40:54 +0200

> Calling IPv4 specific inet_csk_route_req in tcp_check_req
> is a bad idea and crashes machine on IPv6 connections, as reported
> by Valdis Kletnieks
> 
> Also, all we are really interested in is the timestamp
> option in the header, so calling tcp_parse_options()
> with the "estab" set to false flag is an overkill as
> it tries to parse half a dozen other TCP options.
> 
> We know whether timestamp should be enabled or not
> using data from request_sock.
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@codefidence.com>

Applied, thanks.

I assume that your other patch which attempted to fix this isn't
necessary.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/