Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758824AbZKETox (ORCPT ); Thu, 5 Nov 2009 14:44:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758815AbZKETow (ORCPT ); Thu, 5 Nov 2009 14:44:52 -0500 Received: from smtp4.ultrahosting.com ([74.213.175.253]:35493 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758813AbZKETow (ORCPT ); Thu, 5 Nov 2009 14:44:52 -0500 Date: Thu, 5 Nov 2009 10:04:55 -0500 (EST) From: Christoph Lameter X-X-Sender: cl@V090114053VZO-1 To: Dave Jones cc: KAMEZAWA Hiroyuki , "hugh.dickins@tiscali.co.uk" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Tejun Heo Subject: Re: [MM] Make mm counters per cpu instead of atomic In-Reply-To: <20091104234923.GA25306@redhat.com> Message-ID: References: <20091104234923.GA25306@redhat.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 495 Lines: 15 On Wed, 4 Nov 2009, Dave Jones wrote: > On Wed, Nov 04, 2009 at 02:14:41PM -0500, Christoph Lameter wrote: > > > + memset(m, sizeof(struct mm_counter), 0); > > Args wrong way around. Right. It works because percpu_alloc zeroes the data anyways. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/