Message-ID: <4AF307A6.2010101@acm.org>
Date: Thu, 05 Nov 2009 10:13:10 -0700
From: Zan Lynx <zlynx@acm.org>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.4pre) Gecko/20090915 Thunderbird/3.0b4
MIME-Version: 1.0
To: Eric Dumazet <eric.dumazet@gmail.com>
CC: linux-kernel@vger.kernel.org, mk@cm4all.com
Subject: Re: [PATCH] pipe: don't block after data has been written
References: <20091105153147.27473.19570.stgit@woodpecker.roonstrasse.net> <4AF2FD04.4030306@gmail.com> <20091105163603.GA4089@squirrel.roonstrasse.net> <4AF2FF5A.6050205@gmail.com>
In-Reply-To: <4AF2FF5A.6050205@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1334
Lines: 38

On 11/5/09 9:37 AM, Eric Dumazet wrote:
> Max Kellermann a ?crit :
>> On 2009/11/05 17:27, Eric Dumazet<eric.dumazet@gmail.com>  wrote:
>>> Your patch breaks many programs, that dont use poll()/select()
>>>
>>> char result[1000000];
>>> main()
>>> {
>>> 	computethings();
>>> 	write(1, buffer, 1000000);
>>> }
>>
>> Your code does not check the return value of write().  This is a bug.
>>
>
> Welcome to real world.

Yes in the real world there are bugs. The decision is to choose which 
bug you are going to expose. If it was my decision I would make the code 
work as documented, as Max wants to do.

I remember many years ago needing to fix some inetd-called server code 
that got unexpected partial writes on blocking sockets. It was either 
Solaris or HP/UX. So this is nothing new.

In fact I think that Linux will already do short writes if a signal is 
received without restart set for the handler. I found several bugs last 
year in glibc and libstdc++ fwrite and iostreams regarding that.
-- 
Zan Lynx
zlynx@acm.org

"Knowledge is Power.  Power Corrupts.  Study Hard.  Be Evil."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/