Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755553AbZKERcP (ORCPT ); Thu, 5 Nov 2009 12:32:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755045AbZKERcN (ORCPT ); Thu, 5 Nov 2009 12:32:13 -0500 Received: from cantor.suse.de ([195.135.220.2]:42497 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754622AbZKERcK (ORCPT ); Thu, 5 Nov 2009 12:32:10 -0500 Date: Thu, 05 Nov 2009 18:32:14 +0100 Message-ID: From: Takashi Iwai To: Randy Dunlap Cc: Stephen Rothwell , Jaroslav Kysela , linux-next@vger.kernel.org, LKML Subject: Re: [PATCH -next] sound: hda, move hp_bseries_system In-Reply-To: <20091105092230.7765af8c.randy.dunlap@oracle.com> References: <20091105190426.c9cadada.sfr@canb.auug.org.au> <20091105092230.7765af8c.randy.dunlap@oracle.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2107 Lines: 84 At Thu, 5 Nov 2009 09:22:30 -0800, Randy Dunlap wrote: > > From: Randy Dunlap > > Function hp_bseries_system() is always used, outside of > CONFIG_ boundaries/controls, so move it. > > sound/pci/hda/patch_sigmatel.c:5458: error: implicit declaration of function 'hp_bseries_system' > > Signed-off-by: Randy Dunlap Applied now. Thanks! Takashi > --- > sound/pci/hda/patch_sigmatel.c | 40 +++++++++++++++---------------- > 1 file changed, 20 insertions(+), 20 deletions(-) > > --- linux-next-20091105.orig/sound/pci/hda/patch_sigmatel.c > +++ linux-next-20091105/sound/pci/hda/patch_sigmatel.c > @@ -4668,6 +4668,26 @@ static void stac92xx_unsol_event(struct > } > } > > +static int hp_bseries_system(u32 subsystem_id) > +{ > + switch (subsystem_id) { > + case 0x103c307e: > + case 0x103c307f: > + case 0x103c3080: > + case 0x103c3081: > + case 0x103c1722: > + case 0x103c1723: > + case 0x103c1724: > + case 0x103c1725: > + case 0x103c1726: > + case 0x103c1727: > + case 0x103c1728: > + case 0x103c1729: > + return 1; > + } > + return 0; > +} > + > #ifdef CONFIG_PROC_FS > static void stac92hd_proc_hook(struct snd_info_buffer *buffer, > struct hda_codec *codec, hda_nid_t nid) > @@ -4733,26 +4753,6 @@ static int stac92xx_resume(struct hda_co > return 0; > } > > -static int hp_bseries_system(u32 subsystem_id) > -{ > - switch (subsystem_id) { > - case 0x103c307e: > - case 0x103c307f: > - case 0x103c3080: > - case 0x103c3081: > - case 0x103c1722: > - case 0x103c1723: > - case 0x103c1724: > - case 0x103c1725: > - case 0x103c1726: > - case 0x103c1727: > - case 0x103c1728: > - case 0x103c1729: > - return 1; > - } > - return 0; > -} > - > /* > * using power check for controlling mute led of HP notebooks > * check for mute state only on Speakers (nid = 0x10) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/