Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758432AbZKEUOf (ORCPT ); Thu, 5 Nov 2009 15:14:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758335AbZKEUOe (ORCPT ); Thu, 5 Nov 2009 15:14:34 -0500 Received: from cpsmtpm-eml110.kpnxchange.com ([195.121.3.14]:57260 "EHLO CPSMTPM-EML110.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758233AbZKEUOd (ORCPT ); Thu, 5 Nov 2009 15:14:33 -0500 From: Frans Pop To: Mel Gorman Subject: Re: [Bug #14141] order 2 page allocation failures in iwlagn Date: Thu, 5 Nov 2009 21:14:32 +0100 User-Agent: KMail/1.9.9 Cc: Chris Mason , David Rientjes , KOSAKI Motohiro , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Pekka Enberg , Reinette Chatre , Bartlomiej Zolnierkiewicz , Karol Lewandowski , Mohamed Abbas , Jens Axboe , "John W. Linville" , linux-mm@kvack.org References: <3onW63eFtRF.A.xXH.oMTxKB@chimera> <20091020104839.GC11778@csn.ul.ie> <200910262206.13146.elendil@planet.nl> In-Reply-To: <200910262206.13146.elendil@planet.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200911052114.36718.elendil@planet.nl> X-OriginalArrivalTime: 05 Nov 2009 20:14:37.0985 (UTC) FILETIME=[998C4110:01CA5E54] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1707 Lines: 39 On Monday 26 October 2009, Frans Pop wrote: > On Tuesday 20 October 2009, Mel Gorman wrote: > > I've attached a patch below that should allow us to cheat. When it's > > applied, it outputs who called congestion_wait(), how long the timeout > > was and how long it waited for. By comparing before and after sleep > > times, we should be able to see which of the callers has significantly > > changed and if it's something easily addressable. > > The results from this look fairly interesting (although I may be a bad > judge as I don't really know what I'm looking at ;-). > > I've tested with two kernels: > 1) 2.6.31.1: 1 test run > 2) 2.6.31.1 + congestion_wait() reverts: 2 test runs I've taken another look at the data from this debug patch, resulting in these graphs: http://people.debian.org/~fjp/tmp/kernel/congestion.pdf I think the graph may show the reason for the congestion_wait() regression. Horizontal axis shows time, vertical axis shows number of logged congestion_wait calls per type. The top chart is without the revert, the bottom one after the revert. Note how before the revert the graph shows distinct steps: first you get almost exclusively kwapd, followed by almost exclusively alloc_pages and try_to_free. I suspect the periods where kswapd is almost horizontal correspond to the freezes. With the revert the lines for the different functions are almost straight and everything happens much better interspersed. Cheers, FJP -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/