Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757496AbZKFMKP (ORCPT ); Fri, 6 Nov 2009 07:10:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757480AbZKFMKO (ORCPT ); Fri, 6 Nov 2009 07:10:14 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:64017 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757312AbZKFMKN (ORCPT ); Fri, 6 Nov 2009 07:10:13 -0500 From: Arnd Bergmann To: "Eric W. Biederman" Subject: Re: [PATCH 01/11] sysctl: Separate the binary sysctl logic into it's own file. Date: Fri, 6 Nov 2009 13:10:02 +0100 User-Agent: KMail/1.12.2 (Linux/2.6.31-14-generic; KDE/4.3.2; x86_64; ; ) Cc: Christian Borntraeger , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <200911061004.01007.borntraeger@de.ibm.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200911061310.02785.arnd@arndb.de> X-Provags-ID: V01U2FsdGVkX1/MBBw4A7hZ09V2vaMx6Fl05/5cnH1Vf/D2K1c 2XKfMZgBYdLQeS0f8mDVfp3yk5ae18T6FDqSLFcflvgNUd7NyX PRDjhahKz+7uCQpiK72YA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1279 Lines: 32 On Friday 06 November 2009, Eric W. Biederman wrote: > Christian Borntraeger writes: > > > Am Freitag 06 November 2009 01:41:44 schrieb Eric W. Biederman: > >> From: Eric W. Biederman > >> > >> In preparation for more invasive cleanups separate the core > >> binary sysctl logic into it's own file. > >> > >> Signed-off-by: Eric W. Biederman > > > > Hmm, with your patches on Linus git I get the following on s390: > > > > kernel/sysctl_binary.c: In function 'SYSC_sysctl': > > kernel/sysctl_binary.c:126: error: implicit declaration of function > > 'lock_kernel' > > kernel/sysctl_binary.c:129: error: implicit declaration of function > > 'unlock_kernel' > > Bah. A missing smp_lock.h. BTW, there is a patch in the kill-the-BKL tree to push down the BKL further into the sysctl handlers. It may be a good idea to put that into your tree, or to redo the same thing there differently, since you already have a patch series touching this area. Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/