Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759894AbZKFV0Y (ORCPT ); Fri, 6 Nov 2009 16:26:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759666AbZKFV0X (ORCPT ); Fri, 6 Nov 2009 16:26:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22293 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753558AbZKFV0W (ORCPT ); Fri, 6 Nov 2009 16:26:22 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Oleg Nesterov X-Fcc: ~/Mail/linus Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH] ptrace: copy_thread() should clear TIF_SINGLESTEP and X86_EFLAGS_TF In-Reply-To: Oleg Nesterov's message of Friday, 6 November 2009 22:16:37 +0100 <20091106211637.GA1696@redhat.com> References: <20091106211637.GA1696@redhat.com> Emacs: an inspiring example of form following function... to Hell. Message-Id: <20091106212554.BD731CF@magilla.sf.frob.com> Date: Fri, 6 Nov 2009 13:25:54 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 470 Lines: 12 There is also the TIF_FORCED_TF logic to check. Probably it should just call user_disable_single_step() instead. Perhaps copy_process() should just call that and then no per-arch changes would be required. Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/