Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 27 Mar 2002 09:31:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 27 Mar 2002 09:31:29 -0500 Received: from tmr-02.dsl.thebiz.net ([216.238.38.204]:33807 "EHLO gatekeeper.tmr.com") by vger.kernel.org with ESMTP id ; Wed, 27 Mar 2002 09:31:21 -0500 Date: Wed, 27 Mar 2002 09:29:13 -0500 (EST) From: Bill Davidsen To: Neil Brown cc: Linux Kernel Mailing List Subject: Re: Linux 2.4.19pre4-ac1 In-Reply-To: <15521.15136.643851.483671@notabene.cse.unsw.edu.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Mar 2002, Neil Brown wrote: > I think I felt that macros would be very noisy for relatively little > gain. > However I guess > > #define ST 1 /* status*/ > #define FH 17 /* filehandle with length */ > #define AT 22 /* attributes */ > #define WC 7 /* WCC attribute prefix */ > > might make things clearer without being too noisy.... A true member of the "never use a long name when a short one will do" school? You really could sacrifice a few more bytes and use more descriptive names which mean something without looking at the macro definition... Whatever, coding style is personal, I make mine as readable as possible because the next person struggling to understand it in a few years is likely to still be me. -- bill davidsen CTO, TMR Associates, Inc Doing interesting things with little computers since 1979. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/