Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759083AbZKGCSn (ORCPT ); Fri, 6 Nov 2009 21:18:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755373AbZKGCSm (ORCPT ); Fri, 6 Nov 2009 21:18:42 -0500 Received: from hera.kernel.org ([140.211.167.34]:42905 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755131AbZKGCSl (ORCPT ); Fri, 6 Nov 2009 21:18:41 -0500 Message-ID: <4AF4D8FB.7060402@kernel.org> Date: Sat, 07 Nov 2009 11:18:35 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: "Eric W. Biederman" CC: Greg Kroah-Hartman , Kay Sievers , Greg KH , linux-kernel@vger.kernel.org, Cornelia Huck , linux-fsdevel@vger.kernel.org, Eric Dumazet , Benjamin LaHaise , Serge Hallyn Subject: Re: [PATCH 14/13] sysfs: sysfs_setattr remove unnecessary permission check. References: In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 798 Lines: 22 Eric W. Biederman wrote: > inode_change_ok already clears the SGID bit when necessary so there is > no reason for sysfs_setattr to carry code to do the same, and it is > good to kill the extra copy because when I moved the code, I goofed > and in certain corner cases the code will look at the wrong gid. > > Signed-off-by: Eric W. Biederman Acked-by: Tejun Heo I would much prefer this one being prior to 06 but if it's too painful, please at least note it in the description of 06. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/