Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751184AbZKGHuE (ORCPT ); Sat, 7 Nov 2009 02:50:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751100AbZKGHuE (ORCPT ); Sat, 7 Nov 2009 02:50:04 -0500 Received: from fxip-0047f.externet.hu ([88.209.222.127]:56628 "EHLO pomaz-ex.szeredi.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbZKGHuD (ORCPT ); Sat, 7 Nov 2009 02:50:03 -0500 To: ebiederm@xmission.com (Eric W. Biederman) CC: pavel@ucw.cz, miklos@szeredi.hu, alan@lxorguk.ukuu.org.uk, akpm@linux-foundation.org, viro@ZenIV.linux.org.uk, dhowells@redhat.com, hch@infradead.org, adilger@sun.com, mtk.manpages@gmail.com, torvalds@linux-foundation.org, drepper@gmail.com, jamie@shareable.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org In-reply-to: Subject: Re: [PATCH v2 resend] vfs: new O_NODE open flag References: <20091105131545.72b4e319@lxorguk.ukuu.org.uk> <20091106141742.GA1428@ucw.cz> Message-Id: From: Miklos Szeredi Date: Sat, 07 Nov 2009 08:49:33 +0100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 777 Lines: 20 On Fri, 06 Nov 2009, ebiederm@xmission.com (Eric W. Biederman wrote: > So far no one who believes this to be a security hole has found it > worth their while to look at nd->intent.open in proc_pid_follow_link > and write a patch. A rather disgusting patch that would be. The fact is, checking permissions on follow_link makes little to no sense. Consider truncate(2), for example. Will we add another intent for that? I really hope not. I'm more and more convinced, that the current behavior is the right one. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/