Date: Sun, 8 Nov 2009 09:13:14 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Ben Dooks <ben-linux@fluff.org>
Cc: Arve Hj?nnev?g <arve@android.com>,
       kernel list <linux-kernel@vger.kernel.org>,
       linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
       Brian Swetland <swetland@google.com>
Subject: Re: dream: glue for mmc controller
Message-ID: <20091108081314.GA16482@elf.ucw.cz>
References: <20091103105319.GA2492@elf.ucw.cz>
 <20091103105737.GE20341@fluff.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091103105737.GE20341@fluff.org.uk>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3244
Lines: 87

Hi!

> > Good news is that GPIO support seems to work, and I am able to flash
> > the keyboard backlight.
> > 
> > Does anyone have an idea what is wrong? Do I need some more
> > infrastructure to set up (DMA transfers or something?)?
> > 
> > I'm only setting up one mmc channel; I believe the other one is for
> > wifi, and it should work like this...?
> > 								Pavel
> > 
> > diff --git a/arch/arm/mach-msm/Makefile b/arch/arm/mach-msm/Makefile
> > index 91e6f5c..16c0faa 100644
> > --- a/arch/arm/mach-msm/Makefile
> > +++ b/arch/arm/mach-msm/Makefile
> > @@ -6,4 +6,4 @@ obj-y += clock.o clock-7x01a.o
> >  
> >  obj-$(CONFIG_MACH_HALIBUT) += board-halibut.o
> >  
> > -obj-$(CONFIG_MACH_TROUT) += board-dream.o
> > +obj-$(CONFIG_MACH_TROUT) += board-dream.o board-dream-mmc.o board-dream-gpio.o generic_gpio.o
> > diff --git a/arch/arm/mach-msm/board-dream-gpio.c b/arch/arm/mach-msm/board-dream-gpio.c
> > new file mode 100644
> > index 0000000..7e86a99
> > --- /dev/null
> > +++ b/arch/arm/mach-msm/board-dream-gpio.c
> > @@ -0,0 +1,301 @@
> > +/* arch/arm/mach-msm/board-dream-gpio.c
> > + *
> > + * Copyright (C) 2008 Google, Inc.
> > + *
> > + * This software is licensed under the terms of the GNU General Public
> > + * License version 2, as published by the Free Software Foundation, and
> > + * may be copied, distributed, and modified under those terms.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + */
> > +
> > +#include <linux/kernel.h>
> > +#include <linux/errno.h>
> > +#include <linux/irq.h>
> > +#include <linux/pm.h>
> > +#include <linux/sysdev.h>
> > +
> > +#include <asm/io.h>
> > +#include <asm/gpio.h>
> linux/gpio.h
> linux/io.h

I got compile errors when trying to use linux/gpio.h:

arch/arm/mach-msm/board-dream-gpio.c: In function
'dream_gpio_configure':
arch/arm/mach-msm/board-dream-gpio.c:109: error: 'GPIOF_OUTPUT_LOW'
undeclared (first use in this function)
arch/arm/mach-msm/board-dream-gpio.c:109: error: (Each undeclared
identifier is reported only once
arch/arm/mach-msm/board-dream-gpio.c:109: error: for each function it
appears in.)
arch/arm/mach-msm/board-dream-gpio.c:109: error: 'GPIOF_OUTPUT_HIGH'
undeclared (first use in this function)
arch/arm/mach-msm/board-dream-gpio.c: In function 'dream_init_gpio':
arch/arm/mach-msm/board-dream-gpio.c:291: error: 'IRQF_TRIGGER_HIGH'
undeclared (first use in this function)
arch/arm/mach-msm/board-dream-gpio.c:293: error: implicit declaration
of function 'set_irq_wake'

> and why can't use you use gpiolib?

This is what I inherited from google. What advantages are there to it?
I'll eventually take a look.

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/