Date: Sun, 8 Nov 2009 12:02:37 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Andr? Goddard Rosa <andre.goddard@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>, laijs@cn.fujitsu.com,
       davem@davemloft.net, akpm@linux-foundation.org,
       harvey.harrison@gmail.com, linux list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/7] vsprintf: factorize "(null)" string
Message-ID: <20091108110237.GG11372@elte.hu>
References: <b8bf37780911040648h7e4bae3dg21ce15c6b0e680d3@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b8bf37780911040648h7e4bae3dg21ce15c6b0e680d3@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1005
Lines: 36


* Andr? Goddard Rosa <andre.goddard@gmail.com> wrote:

> @@ -546,12 +548,12 @@ static char *number(char *buf, char *end,
> unsigned long long num,
>  	return buf;
>  }
> 
> -static char *string(char *buf, char *end, char *s, struct printf_spec spec)
> +static char *string(char *buf, char *end, const char *s, struct
> printf_spec spec)

FYI, your patches have such linewraps, so the patches wont apply:

 patch: **** malformed patch at line 47: unsigned long long num,

See Documentation/email-clients.txt about how to send patches without 
such problems.

Mind resending with this fixed?

Also, this RFC patch of yours:

  vsprintf: reuse almost identical simple_strtoulX() functions

looks nice too IMO - mind including it in your series?

Thanks,

	Ingo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/