Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754069AbZKHM1y (ORCPT ); Sun, 8 Nov 2009 07:27:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753956AbZKHM1x (ORCPT ); Sun, 8 Nov 2009 07:27:53 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:54968 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753946AbZKHM1w (ORCPT ); Sun, 8 Nov 2009 07:27:52 -0500 Date: Sun, 8 Nov 2009 13:27:39 +0100 From: Ingo Molnar To: Michael Cree Cc: linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Peter Zijlstra , Paul Mackerras , Andrew Morton Subject: Re: [PATCH] [alpha] Add minimal support for software performance events. Message-ID: <20091108122739.GD11372@elte.hu> References: <1256545926-6972-1-git-send-email-mcree@orcon.net.nz> <20091026084854.GA26990@elte.hu> <4AE6AAD3.3000102@orcon.net.nz> <20091108122226.GC11372@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091108122226.GC11372@elte.hu> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1368 Lines: 37 * Ingo Molnar wrote: > > * Michael Cree wrote: > > > > Should be done not by removing the stack-protector build > > > unconditionally - but by auto-testing whether stackprotector is > > > supported by GCC and using it if yes. > > > > Revised patch attached. It includes a test that the compiler doesn't > > bomb out with -fstack-protector-all and only adds the option to CFLAGS > > if ok. But I have had to put the test below the definition of the > > macro CC. This has the side effect of separating the addition of > > -fstack-protector-all from the main definitions of CFLAGS and > > ALL_CFLAGS, and is not ideal in my opinion. The patch also removes > > -Wcast-align (I forgot to say that in the commit message of the > > patch). > > Nice, i'll queue this up for Linus. > > Your S-O-B line was missing from this second patch - i presume you > intended it to be included, right? Mind resending the patch against latest -tip? http://people.redhat.com/mingo/tip.git/README There's been other changes in this area so your patch does not apply anymore. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/