Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754890AbZKILxA (ORCPT ); Mon, 9 Nov 2009 06:53:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754705AbZKILw7 (ORCPT ); Mon, 9 Nov 2009 06:52:59 -0500 Received: from ey-out-2122.google.com ([74.125.78.24]:24642 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754228AbZKILw6 (ORCPT ); Mon, 9 Nov 2009 06:52:58 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=svLAzQjd0sYCKZMUX4GPzkN5dyorQLlGzsEYWxCq/1EgqVmTMc9APEZ2sPTvrG4s0P /JAIB2JG4jyglbr5NQQMInLGgODWhYtwEdsQUyrpHmmdN7UMgi6BLxhfaK+zVBaLHtSG qDdjxp8EiQTccIaNwV1Z+SiI8W/r/zJ+F2fdQ= Date: Mon, 9 Nov 2009 12:53:05 +0100 From: Frederic Weisbecker To: Wu Zhangjin Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, Thomas Gleixner , Ralf Baechle , Nicholas Mc Guire , Richard Sandiford , David Daney , Adam Nemet , Patrik Kluba Subject: Re: [PATCH -v5 08/11] tracing: not trace mips_timecounter_init() in MIPS Message-ID: <20091109115303.GB5206@nowhere> References: <54c417629e91f40b2bbb4e08cda2a4e6527824c0.1256483735.git.wuzhangjin@gmail.com> <29bccff04932e993ecd9f516d8b6dcf84e2ceecf.1256483735.git.wuzhangjin@gmail.com> <72f2270f7b6e01ca7a4cdf4ac8c21778e5d9652f.1256483735.git.wuzhangjin@gmail.com> <6140dd8f4e1783e5ac30977cf008bb98e4698322.1256483735.git.wuzhangjin@gmail.com> <49b3c441a57f4db423732f81432a3450ccb3240e.1256483735.git.wuzhangjin@gmail.com> <1256550156.5642.148.camel@falcon> <20091102214351.GI4880@nowhere> <1257741072.3451.27.camel@falcon.domain.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1257741072.3451.27.camel@falcon.domain.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1217 Lines: 37 On Mon, Nov 09, 2009 at 12:31:12PM +0800, Wu Zhangjin wrote: > I think if we use something like __mips_notrace here, we may get lots of > __ARCH_notraces here too, 'Cause some other platforms(at least, as I > know, Microblaze will do it too) may also need to add one here, it will > become: > > __mips_notrace __ARCH1_notrace __ARCH2_notrace .... foo() {...} > > A little ugly ;) Yeah :) I thought Mips would be the only one to do that. > and If a new platform need it's __ARCH_notrace, they need to touch the > common part of ftrace, more side-effects! > > but with __arch_notrace, the archs only need to touch it's own part, > Although there is a side-effect as you mentioned above ;) > > So, what should we do? > > Regards, > Wu Zhangjin > Why not __time ? As it's normal that such few functions that are used to read the timecounter have fair chances to be __no_trace on archs like MIPS. Interested archs would just need to override a default stub __time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/