Date: Mon, 9 Nov 2009 15:02:02 -0500
From: Aristeu Rozanski <aris@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
       Peter Zijlstra <a.p.zijlstra@chello.nl>,
       =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <fweisbec@gmail.com>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86: introduce NMI_AUTO as nmi_watchdog option
Message-ID: <20091109200201.GT18613@redhat.com>
References: <20091103171054.GB25437@redhat.com> <20091104114630.GA16993@elte.hu> <20091104151929.GH18613@redhat.com> <20091104155641.GA11444@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091104155641.GA11444@elte.hu>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2142
Lines: 44

> > > > NMI_AUTO is a new nmi_watchdog option that makes LAPIC be tried first 
> > > > and if the CPU isn't supported, IOAPIC will be used. It's useful in 
> > > > cases where NMI watchdog is enabled by default in a kernel built for 
> > > > different machines. It can be configured by default or selected with 
> > > > nmi_watchdog=3 or nmi_watchdog=auto parameters.
> > > 
> > > What i'd like to see for the NMI watchdog is much more ambitious than 
> > > this: the use of perf events to run a periodic NMI callback.
> > > 
> > > The NMI watchdog would cause the creation of a per-cpu perf_event 
> > > structure (in-kernel). All x86 CPUs that have perf event support (the 
> > > majority of them) will thus be able to have an NMI watchdog using a 
> > > nice, generic piece of code and we'd be able to phase out the open-coded 
> > > NMI watchdog code.
> > > 
> > > The user would not notice much from this: we'd still have the 
> > > /proc/sys/kernel/nmi_watchdog toggle to turn it on/off, and we'd still 
> > > have the nmi_watchog= boot parameter as well. But the underlying 
> > > implementation would be far more generic and far more usable than the 
> > > current code.
> > > 
> > > Would you be interested in moving the NMI watchdog code in this 
> > > direction? Most of the perf events changes (callbacks, helpers for 
> > > in-kernel event allocations, etc.) are in latest -tip already, so you 
> > > could use that as a base.
> >
> > but that would work only for LAPIC. You're suggesting killing IOAPIC 
> > mode too?
> 
> Would it be a big loss, with all modern systems expected to have a 
> working lapic based NMI source? I wrote the IOAPIC mode originally but i 
> dont feel too attached to it ;-)
ok, fair enough. but since it'll be another implementation, do you mind
applying the patches I submitted so they can be used until the new
implementation is in place?

-- 
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/