DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=GM5Hwi/pRRqDfb1bTdVN49FKXm/ysUeJEq/JZlr9FvJrqZwIQWfFXFU0/fKLlA/bbz
         UlVheaULzw4pvEJ7Tg+zLwUjOznUFECTQKb8nVv8LYVnIDe5U+ZY6mAu8dxzUkCpM85r
         MGDrvoQ1ijcakHgUxYqlCJiwIyYz4JUGvWI4A=
MIME-Version: 1.0
In-Reply-To: <84144f020911091213j393a9761pe13808d1e091e169@mail.gmail.com>
References: <1256712464-21472-1-git-send-email-fujita.tomonori@lab.ntt.co.jp>
	 <1256712464-21472-8-git-send-email-fujita.tomonori@lab.ntt.co.jp>
	 <84144f020911091213j393a9761pe13808d1e091e169@mail.gmail.com>
Date: Mon, 9 Nov 2009 22:21:48 +0200
Message-ID: <84144f020911091221n1d025d9bv3915751bf474b47a@mail.gmail.com>
Subject: Re: [PATCH 07/10] bootmem: add free_bootmem_late
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-kernel@vger.kernel.org, chrisw@sous-sol.org, dwmw2@infradead.org,
       joerg.roedel@amd.com, mingo@elte.hu,
       Andrew Morton <akpm@linux-foundation.org>,
       Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1115
Lines: 26

On Mon, Nov 9, 2009 at 10:13 PM, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
>> ? ? ? ?for (cursor = start; cursor < end; cursor += BITS_PER_LONG) {
>> - ? ? ? ? ? ? ? unsigned long idx, vec;
>> + ? ? ? ? ? ? ? unsigned long vec;
>>
>> - ? ? ? ? ? ? ? idx = cursor - start;
>> - ? ? ? ? ? ? ? vec = ~map[idx / BITS_PER_LONG];
>> + ? ? ? ? ? ? ? if (map) {
>> + ? ? ? ? ? ? ? ? ? ? ? unsigned long idx = cursor - start;
>> + ? ? ? ? ? ? ? ? ? ? ? vec = ~map[idx / BITS_PER_LONG];
>> + ? ? ? ? ? ? ? } else {
>> + ? ? ? ? ? ? ? ? ? ? ? if (end - cursor >= BITS_PER_LONG)
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? vec = ~0UL;
>
> Why do we need the above?

OK, I figured that out. I'm not sure why you want to play tricks with
"vec" when you could just add a new helper that calls
__free_pages_bootmem() for the full contiguous page range.

                                Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/