Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754799AbZKJJiI (ORCPT ); Tue, 10 Nov 2009 04:38:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753441AbZKJJiH (ORCPT ); Tue, 10 Nov 2009 04:38:07 -0500 Received: from elettra.colt-to.towertech.it ([213.215.222.70]:44141 "EHLO elettra.colt-to.towertech.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752942AbZKJJiG convert rfc822-to-8bit (ORCPT ); Tue, 10 Nov 2009 04:38:06 -0500 X-Greylist: delayed 433 seconds by postgrey-1.27 at vger.kernel.org; Tue, 10 Nov 2009 04:38:06 EST Date: Tue, 10 Nov 2009 10:30:54 +0100 From: Alessandro Zummo To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, Sascha Hauer , Paul Gortmaker , rtc-linux@googlegroups.com Subject: Re: [PATCH RESENT] [RTC] Add Freescale MC13783 RTC driver Message-ID: <20091110103054.516cc03b@linux.lan.towertech.it> In-Reply-To: <1257841967-6084-1-git-send-email-u.kleine-koenig@pengutronix.de> References: <4AF2E9E7.9050807@epfl.ch> <1257841967-6084-1-git-send-email-u.kleine-koenig@pengutronix.de> Organization: Tower Technologies X-Mailer: Sylpheed X-This-Is-A-Real-Message: Yes Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 811 Lines: 30 On Tue, 10 Nov 2009 09:32:47 +0100 Uwe Kleine-K?nig wrote: > + ret = mc13783_irq_request_nounmask(priv->mc13783, MC13783_IRQ_1HZ, > + mc13783_rtc_update_handler, DRIVER_NAME, priv); > + if (ret) > + goto err_update_irq_request; > + > + mc13783_unlock(priv->mc13783); > + > + priv->rtc = rtc_device_register(pdev->name, > + &pdev->dev, &mc13783_rtc_ops, THIS_MODULE); > + isn't better to enable irqs after registration? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/