Date: Tue, 10 Nov 2009 11:09:42 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       device@lanana.org, rubini@vision.unipv.it, gregkh@suse.de,
       cluster-devel@redhat.com
Subject: Re: [PATCH] misc: use a proper range for minor number dynamic
 allocation
Message-ID: <20091110110942.4cb70b13@lxorguk.ukuu.org.uk>
In-Reply-To: <20091109220257.GD12217@vespa.holoscopio.com>
References: <1256340497-19320-1-git-send-email-cascardo@holoscopio.com>
	<20091109132836.6cf7f559.akpm@linux-foundation.org>
	<20091109220257.GD12217@vespa.holoscopio.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 833
Lines: 20

> We could consider buggy the caller which asks for the same device name
> more than once, without unregistering the first device. But better safe

If they ask for the same name we certainly should. Probably we should
error that request and use WARN_ON() to shame the offender in
kerneloops.org.

> than sorry: we should protect the correct drivers from the buggy ones
> and avoid a depletion of the minor numbers. And, in case the driver core
> returns another error for another reason (from device_create), we do the
> right thing.

Agreed we need to protect the working drivers.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/