Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756125AbZKJLvE (ORCPT ); Tue, 10 Nov 2009 06:51:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755447AbZKJLu6 (ORCPT ); Tue, 10 Nov 2009 06:50:58 -0500 Received: from ns.dcl.info.waseda.ac.jp ([133.9.216.194]:61588 "EHLO ns.dcl.info.waseda.ac.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214AbZKJLu4 (ORCPT ); Tue, 10 Nov 2009 06:50:56 -0500 From: Hitoshi Mitake To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Hitoshi Mitake , Peter Zijlstra , Paul Mackerras Subject: [PATCH 1/3] perf bench: Clean bench/bench.h Date: Tue, 10 Nov 2009 20:50:53 +0900 Message-Id: <1257853855-28934-2-git-send-email-mitake@dcl.info.waseda.ac.jp> X-Mailer: git-send-email 1.6.5.2 In-Reply-To: <1257853855-28934-1-git-send-email-mitake@dcl.info.waseda.ac.jp> References: <1257853855-28934-1-git-send-email-mitake@dcl.info.waseda.ac.jp> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1905 Lines: 57 This patch cleans bench/bench.h for readability according to Ingo's advice. Actually, this patch is completely same with one Ingo posted. | A (very) small detail about initializers in bench.h: | | - No need to break the line for function prototypes, they are more | readable in a single line. (even if checkpatch complains about it) | | - We try to align definitions / structure fields vertically, to make it | all a bit more readable. Signed-off-by: Hitoshi Mitake Cc: Peter Zijlstra Cc: Paul Mackerras --- tools/perf/bench/bench.h | 16 +++++++--------- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/tools/perf/bench/bench.h b/tools/perf/bench/bench.h index 42167ea..9fbd8d7 100644 --- a/tools/perf/bench/bench.h +++ b/tools/perf/bench/bench.h @@ -1,17 +1,15 @@ #ifndef BENCH_H #define BENCH_H -extern int bench_sched_messaging(int argc, const char **argv, - const char *prefix); -extern int bench_sched_pipe(int argc, const char **argv, - const char *prefix); +extern int bench_sched_messaging(int argc, const char **argv, const char *prefix); +extern int bench_sched_pipe(int argc, const char **argv, const char *prefix); -#define BENCH_FORMAT_DEFAULT_STR "default" -#define BENCH_FORMAT_DEFAULT 0 -#define BENCH_FORMAT_SIMPLE_STR "simple" -#define BENCH_FORMAT_SIMPLE 1 +#define BENCH_FORMAT_DEFAULT_STR "default" +#define BENCH_FORMAT_DEFAULT 0 +#define BENCH_FORMAT_SIMPLE_STR "simple" +#define BENCH_FORMAT_SIMPLE 1 -#define BENCH_FORMAT_UNKNOWN -1 +#define BENCH_FORMAT_UNKNOWN -1 extern int bench_format; -- 1.6.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/