To: Jeff Layton <jlayton@redhat.com>
CC: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
       linux-nfs@vger.kernel.org, ebiederm@xmission.com, adobriyan@gmail.com,
       viro@ZenIV.linux.org.uk, jamie@shareable.org
In-reply-to: <1257870456-31188-1-git-send-email-jlayton@redhat.com> (message
	from Jeff Layton on Tue, 10 Nov 2009 11:27:34 -0500)
Subject: Re: [PATCH 0/2] vfs: ensure that dentries are revalidated on open (try #2)
References: <1257870456-31188-1-git-send-email-jlayton@redhat.com>
Message-Id: <E1N884c-0006Br-Je@pomaz-ex.szeredi.hu>
From: Miklos Szeredi <miklos@szeredi.hu>
Date: Wed, 11 Nov 2009 08:57:02 +0100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 973
Lines: 22

On Tue, 10 Nov 2009, Jeff Layton wrote:
> This is the second attempt to fix this problem. The first one attempted
> to fix this in procfs, but Eric Biederman pointed out that file bind
> mounts have a similar problem. This set attempts to fix the issue at a
> higher level, in the generic VFS layer.

I suspect the correct fix would be to clean up the open API so that
NFSv4 doesn't have to hack its stateful open routine into the
->lookup() and ->d_revalidate() methods.

Having said that, doing revalidation for proc symlinks and bind mounts
(and not just for opens) might make sense.  This is something similar
to FS_REVAL_DOT, so perhaps make it conditional on this flag (or a
new, appropriately named one).

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/