DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=KfRfC8jMOnIZWLFJ6EFarCd+hNmPZAhTwHuG+j6go05YZeLkTbGcHWEX+DuUZPXNE2
         ghO8ZpB+EdRQKe4we20nJdFxqgcVMrNaOSrWMcpWoaKTq1H5GvpHQst0GFoirM4M4IbZ
         fXsTKJfNziykgPfbec04uudbyIQFxVHVDGPgg=
MIME-Version: 1.0
In-Reply-To: <2bd27b061789ed14dd80816fd987273ae33ffbd1.1257864802.git.andre.goddard@gmail.com>
References: <cover.1257864802.git.andre.goddard@gmail.com>
	 <2bd27b061789ed14dd80816fd987273ae33ffbd1.1257864802.git.andre.goddard@gmail.com>
Date: Wed, 11 Nov 2009 13:09:57 -0200
Message-ID: <a4c8a6d00911110709j65b54875sb9e56edf0a32c28d@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] bsearch: prevent overflow when computing middle 
	comparison element
From: Thiago Farina <tfransosi@gmail.com>
To: =?UTF-8?Q?Andr=C3=A9_Goddard_Rosa?= <andre.goddard@gmail.com>
Cc: tabbott@ksplice.com, alan-jenkins@tuffmail.co.uk, rusty@rustcorp.com.au,
       linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 844
Lines: 19

On Tue, Nov 10, 2009 at 1:00 PM, André Goddard Rosa
<andre.goddard@gmail.com> wrote:
>  void *bsearch(const void *key, const void *base, size_t num, size_t size,
>              int (*cmp)(const void *key, const void *elt))
>  {
> -       int start = 0, end = num, mid, result;
> +       size_t start = 0, end = num;
> +       int result;
>
>        while (start < end) {
> -               mid = (start + end) / 2;
> +               size_t mid = start + (end - start) / 2;
I think it is more readable if you could keep the mid variable outside
of the while loop.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/