Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758502AbZKKUM5 (ORCPT ); Wed, 11 Nov 2009 15:12:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757304AbZKKUM4 (ORCPT ); Wed, 11 Nov 2009 15:12:56 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:36659 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757261AbZKKUMz (ORCPT ); Wed, 11 Nov 2009 15:12:55 -0500 Date: Wed, 11 Nov 2009 12:11:00 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: "Rafael J. Wysocki" cc: Oleg Nesterov , Thomas Gleixner , Mike Galbraith , Ingo Molnar , LKML , pm list , Greg KH , Jesse Barnes , Tejun Heo , Marcel Holtmann , linux-bluetooth@vger.kernel.org Subject: Re: GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume (was: Re: Help needed: Resume problems in 2.6.32-rc, perhaps related to preempt_count leakage in keventd) In-Reply-To: <200911112100.16561.rjw@sisk.pl> Message-ID: References: <200911091250.31626.rjw@sisk.pl> <20091111161348.GA27394@redhat.com> <200911112100.16561.rjw@sisk.pl> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1234 Lines: 35 On Wed, 11 Nov 2009, Rafael J. Wysocki wrote: > > I applied the patch and this is the result of 'dmesg | grep ERR' after 10-or-so > consecutive suspend-resume and hibernate-resume cycles: > > [ 129.008689] ERR!! btusb_waker+0x0/0x27 [btusb] > [ 166.477373] ERR!! btusb_waker+0x0/0x27 [btusb] > [ 203.983665] ERR!! btusb_waker+0x0/0x27 [btusb] > [ 241.636547] ERR!! btusb_waker+0x0/0x27 [btusb] > > which kind of confirms my previous observation that the problem was not > reproducible without Bluetooth. .. and that btusb thing matches my observation that only a few BT drivers seem to use workqueues, and btusb_disconnect() isn't doing any work cancel. > I'm going to test the appended patch, then. Hmm. the USB disconnect doesn't call hci_dev_put(), it calls hci_free_dev() and doesn't seem to call the ->destruct thing. Although again, maybe that gets called indirectly. So I'd put the cancel work in the actual disconnect routine. But maybe thar's just me. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/