Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759247AbZKKVLA (ORCPT ); Wed, 11 Nov 2009 16:11:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758847AbZKKVLA (ORCPT ); Wed, 11 Nov 2009 16:11:00 -0500 Received: from smtp-out002.kontent.com ([81.88.40.216]:50327 "EHLO smtp-out002.kontent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758368AbZKKVK7 (ORCPT ); Wed, 11 Nov 2009 16:10:59 -0500 From: Oliver Neukum To: Marcel Holtmann Subject: Re: GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume (was: Re: Help needed: Resume problems in 2.6.32-rc, perhaps related to preempt_count leakage in keventd) Date: Wed, 11 Nov 2009 22:13:30 +0100 User-Agent: KMail/1.12.2 (Linux/2.6.32-rc6-0.1-default; KDE/4.3.1; x86_64; ; ) Cc: Linus Torvalds , "Rafael J. Wysocki" , Thomas Gleixner , Mike Galbraith , Ingo Molnar , LKML , pm list , Greg KH , Jesse Barnes , Tejun Heo , Oleg Nesterov , linux-bluetooth@vger.kernel.org References: <200911091250.31626.rjw@sisk.pl> <1257970719.21467.4.camel@violet> In-Reply-To: <1257970719.21467.4.camel@violet> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <200911112213.30673.oliver@neukum.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1282 Lines: 28 Am Mittwoch, 11. November 2009 21:18:39 schrieb Marcel Holtmann: > > I'm looking at btusb_disconnect(), for example. It's one of the few BT > > drivers that seem to use workqueues, and I'm not seeing a > > cancel_work_sync() in the disconnect routine - but maybe the > > btusb_close() routine is called indirectly some way that I just don't > > see. > > so the btusb_close() should be called before btusb_destruct() and the > destruct() callback is only when the last reference count gets dropped > and we do have to free the memory. So it seems we are doing something > wrong in btusb_close(). The close() callback is triggered via > hci_unregister_dev() from btusb_disconnect(). > > As it seems the btusb_close() only cancels the work workqueue and not > the waker workqueue. Could that be the problem. Yes, btusb_close() needs to cancel the waker workqueue, too. In addition, in order to avoid a memory leak it must call usb_scuttle_anchored_urbs(&data->deferred) to make sure any deferred data is destroyed. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/