Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759688AbZKLAAm (ORCPT ); Wed, 11 Nov 2009 19:00:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759501AbZKLAAm (ORCPT ); Wed, 11 Nov 2009 19:00:42 -0500 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:51937 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759486AbZKLAAl (ORCPT ); Wed, 11 Nov 2009 19:00:41 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Message-ID: <4AFB5019.7030901@jp.fujitsu.com> Date: Thu, 12 Nov 2009 09:00:25 +0900 From: Hidetoshi Seto User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Stanislaw Gruszka CC: Peter Zijlstra , Spencer Candland , linux-kernel@vger.kernel.org, Ingo Molnar , Oleg Nesterov Subject: Re: [PATCH] fix granularity of task_u/stime() References: <4AF0C97F.7000603@bluehost.com> <4AF123F5.50407@jp.fujitsu.com> <4AF26176.4080307@jp.fujitsu.com> <1257778154.4108.341.camel@laptop> <4AF8FD3C.2090008@jp.fujitsu.com> <4AF8FE76.406@jp.fujitsu.com> <20091111121150.GA2549@dhcp-lab-161.englab.brq.redhat.com> In-Reply-To: <20091111121150.GA2549@dhcp-lab-161.englab.brq.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1459 Lines: 47 Stanislaw Gruszka wrote: > On Tue, Nov 10, 2009 at 02:47:34PM +0900, Hidetoshi Seto wrote: >> Remove casting to clock_t from task_u/stime(), and keep granularity of >> cputime_t over the calculation. >> >> Signed-off-by: Hidetoshi Seto >> --- >> kernel/sched.c | 21 ++++++++++++--------- >> 1 files changed, 12 insertions(+), 9 deletions(-) >> >> diff --git a/kernel/sched.c b/kernel/sched.c >> index 28dd4f4..1632e82 100644 >> --- a/kernel/sched.c >> +++ b/kernel/sched.c >> @@ -5171,41 +5171,44 @@ cputime_t task_stime(struct task_struct *p) >> return p->stime; >> } >> #else >> + >> +#ifndef nsecs_to_cputime >> +# define nsecs_to_cputime(__nsecs) msecs_to_cputime((__nsecs) / NSEC_PER_MSEC) >> +#endif >> + > > I would like to test, but unfortunately with the patch kernel not build > on my system: > > kernel/built-in.o: In function `task_utime': > /usr/src/rhel5/linux-2.6/kernel/sched.c:5187: undefined reference to > `__udivdi3' > kernel/built-in.o: In function `task_stime': > /usr/src/rhel5/linux-2.6/kernel/sched.c:5208: undefined reference to > `__udivdi3' > make: *** [.tmp_vmlinux1] Error 1 Wow, what arch? Could you provide your .config? Thanks, H.Seto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/