Date: Thu, 12 Nov 2009 10:25:18 +0100
From: Anders Larsen <al@alarsen.net>
Subject: Re: [PATCH 4/4] fs/qnx4: decrement sizeof size in strncmp
To: Julia Lawall <julia@diku.dk>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
In-Reply-To: <Pine.LNX.4.64.0911120849260.16627@ask.diku.dk> (from
	julia@diku.dk on Thu Nov 12 08:49:44 2009)
Message-Id: <1258017918l.26867l.0l@i-dmzi_al.realan.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
References: <Pine.LNX.4.64.0911120849260.16627@ask.diku.dk>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 741
Lines: 22

On 2009-11-12 08:49:44, Julia Lawall wrote:
> As observed by Joe Perches, sizeof of a constant string includes the
> trailing 0.  If what is wanted is to check the initial characters of
> another string, this trailing 0 should not be taken into account.  If an
> exact match is wanted, strcmp should be used instead.

Good catch.
However, in this case an exact match (with the string ".bitmap") is what
is needed, so

NAK

Will you cook up a new patch changing strncmp to strcmp?

Cheers
Anders

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/