Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753120AbZKLPWc (ORCPT ); Thu, 12 Nov 2009 10:22:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752790AbZKLPWb (ORCPT ); Thu, 12 Nov 2009 10:22:31 -0500 Received: from smtp.ultrahosting.com ([74.213.174.254]:54330 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752750AbZKLPWb (ORCPT ); Thu, 12 Nov 2009 10:22:31 -0500 Date: Thu, 12 Nov 2009 10:20:29 -0500 (EST) From: Christoph Lameter X-X-Sender: cl@V090114053VZO-1 To: KAMEZAWA Hiroyuki cc: Minchan Kim , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hugh.dickins@tiscali.co.uk" , akpm@linux-foundation.org, "kosaki.motohiro@jp.fujitsu.com" Subject: Re: [PATCH] show per-process swap usage via procfs v3 In-Reply-To: <20091111112539.71dfac31.kamezawa.hiroyu@jp.fujitsu.com> Message-ID: References: <20091104152426.eacc894f.kamezawa.hiroyu@jp.fujitsu.com> <28c262360911050711k47a63896xe4915157664cb822@mail.gmail.com> <20091106084806.7503b165.kamezawa.hiroyu@jp.fujitsu.com> <20091106134030.a94665d1.kamezawa.hiroyu@jp.fujitsu.com> <28c262360911060719y45f4b58ex2f13853f0d142656@mail.gmail.com> <20091111112539.71dfac31.kamezawa.hiroyu@jp.fujitsu.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1176 Lines: 39 On Wed, 11 Nov 2009, KAMEZAWA Hiroyuki wrote: > > Index: mm-test-kernel/include/linux/mm_types.h > =================================================================== > --- mm-test-kernel.orig/include/linux/mm_types.h > +++ mm-test-kernel/include/linux/mm_types.h > @@ -228,6 +228,7 @@ struct mm_struct { > */ > mm_counter_t _file_rss; > mm_counter_t _anon_rss; > + mm_counter_t _swap_usage; This is going to be another hit on vm performance if we get down this road. At least put #ifdef CONFIG_SWAP ? around this so that we can switch it off? > @@ -597,7 +600,9 @@ copy_one_pte(struct mm_struct *dst_mm, s > &src_mm->mmlist); > spin_unlock(&mmlist_lock); > } > - if (is_write_migration_entry(entry) && > + if (!non_swap_entry(entry)) > + rss[2]++; > + else if (is_write_migration_entry(entry) && > is_cow_mapping(vm_flags)) { > /* What are the implications for fork performance? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/