Date: Thu, 12 Nov 2009 17:56:49 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Eran Liberty <liberty@extricom.com>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial_core: avoid Break bouncing
Message-ID: <20091112175649.145cbf18@lxorguk.ukuu.org.uk>
In-Reply-To: <20091112140504.6daf3824@pedra.chehab.org>
References: <20091112140504.6daf3824@pedra.chehab.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1342
Lines: 34

On Thu, 12 Nov 2009 14:05:04 -0200
Mauro Carvalho Chehab <mchehab@redhat.com> wrote:

> From: Eran Liberty <liberty@extricom.com>
> 
> On some boxes, Break signal bounces, causing sysrq code to fail with some
> serial interfaces.
> 
> A solution were posted on LKML in 2008:
> http://lkml.indiana.edu/hypermail/linux/kernel/0809.2/0730.html
> 
> However, the fix weren't applied upstream.

Because it was NAKked at the time as it seemed to be a bug in Eran's
hardware platform not a generic problem and also because it breaks
autobauding on break as used by some (particularly older) software.

It's still NAKked and it would be helpful if people resubmitting old
stuff also looked through the thread attached the original submission.

You seem to have a single case of a user with some kind of buggy uart or
possibly other weirdness going on. That's probably worth investigating
more deeply but the patch NAKked before is not the solution due to its
side effects

(also btw it'll upset other people who script their sysrq stuff including
breaks and don't expect strange timing limits)

NAK again
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/