Message-ID: <4AFC5214.9030108@trash.net>
Date: Thu, 12 Nov 2009 19:21:08 +0100
From: Patrick McHardy <kaber@trash.net>
User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701)
MIME-Version: 1.0
To: Patrick Mullaney <pmullaney@novell.com>
CC: linux-kernel@vger.kernel.org, arnd@arnd.de, netdev@vger.kernel.org,
       bridge@lists.linux-foundation.rog
Subject: Re: [PATCH] netdevice: provide common routine for macvlan and vlan
 operstate management
References: <4AFAD86A.9070506@trash.net> <20091112180137.10186.9386.stgit@mimic.site>
In-Reply-To: <20091112180137.10186.9386.stgit@mimic.site>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 940
Lines: 19

Patrick Mullaney wrote:
> This patch is intended to address your comment on moving the operstate
> transition function. I decided to move it to netdevice.h, perhaps that
> is a bad idea? It didn't seem to logically fall into dev.c or link_watch.c.
> I am not against moving them to either one though. Your other comments
> are addressed and I will send out a second series once this gets
> reviewed and agreed on.

Thanks. I don't mind much where exactly it is located, but I'd prefer
to not have it inlined. It doesn't seem terribly wrong to move it to
dev.c, there are even some helpers for stacked devices already, like
address list synchronization.

Besides that the patch looks fine to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/